[fix][break] fix #148: ServiceException.getMessage includes unsafe args #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsafe args This change provides parity with safe-logging Safe*Exception types, see palantir/safe-logging#76 By providing all argument data in the exception message we provide full context to logging systems which do not understand safe-logging types.
carterkozak
force-pushed
the
ckozak/gh148
branch
from
7885cab to
f81d07a
Compare
|
👍 |
carterkozak
assigned
dansanduleac,
iamdanfox,
uschi2000,
ferozco,
esword and
dsd987 and unassigned
dansanduleac,
iamdanfox,
uschi2000 and
ferozco
dansanduleac
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change provides parity with safe-logging Safe*Exception
types, see palantir/safe-logging#76
By providing all argument data in the exception message we
provide full context to logging systems which do not understand
safe-logging types.