diff --git a/.baseline/checkstyle/checkstyle.xml b/.baseline/checkstyle/checkstyle.xml
index efc641dfd..f541b63e2 100644
--- a/.baseline/checkstyle/checkstyle.xml
+++ b/.baseline/checkstyle/checkstyle.xml
@@ -127,6 +127,11 @@
+
+
+
+
+
@@ -417,6 +422,7 @@
+
@@ -430,7 +436,7 @@
-
+
@@ -463,7 +469,7 @@
-
+
diff --git a/build.gradle b/build.gradle
index 75519dacb..c47ecb5a3 100644
--- a/build.gradle
+++ b/build.gradle
@@ -29,7 +29,7 @@ buildscript {
classpath 'com.netflix.nebula:gradle-info-plugin:5.1.0'
classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.8.4'
classpath 'com.netflix.nebula:nebula-publishing-plugin:13.6.1'
- classpath 'com.palantir.baseline:gradle-baseline-java:0.51.1'
+ classpath 'com.palantir.baseline:gradle-baseline-java:2.9.1'
classpath 'com.palantir.gradle.conjure:gradle-conjure:4.13.1'
classpath 'com.palantir.gradle.gitversion:gradle-git-version:0.12.2'
classpath 'gradle.plugin.org.inferred:gradle-processors:3.1.0'
diff --git a/conjure-core/src/main/java/com/palantir/conjure/defs/ConjureParserUtils.java b/conjure-core/src/main/java/com/palantir/conjure/defs/ConjureParserUtils.java
index 73da9db35..ca9c7b788 100644
--- a/conjure-core/src/main/java/com/palantir/conjure/defs/ConjureParserUtils.java
+++ b/conjure-core/src/main/java/com/palantir/conjure/defs/ConjureParserUtils.java
@@ -72,6 +72,7 @@
import com.palantir.conjure.spec.UnionDefinition;
import com.palantir.conjure.visitor.DealiasingTypeVisitor;
import com.palantir.conjure.visitor.TypeDefinitionVisitor;
+import com.palantir.logsafe.exceptions.SafeIllegalArgumentException;
import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
@@ -97,7 +98,7 @@ public static String parsePackageOrElseThrow(
Optional defaultPackage) {
String packageName = conjurePackage
.map(p -> p.name())
- .orElseGet(() -> defaultPackage.orElseThrow(() -> new IllegalArgumentException(
+ .orElseGet(() -> defaultPackage.orElseThrow(() -> new SafeIllegalArgumentException(
// TODO(rfink): Better errors: Can we provide context on where exactly no package was provided?
"Must provide default conjure package or "
+ "explicit conjure package for every object and service")));
@@ -373,7 +374,7 @@ private static Optional parseAuthType(
case NONE:
return Optional.empty();
default:
- throw new IllegalArgumentException("Unrecognized auth type.");
+ throw new SafeIllegalArgumentException("Unrecognized auth type.");
}
}
@@ -415,14 +416,14 @@ private static ParameterType parseParameterType(
return ParameterType.body(BodyParameterType.of());
}
case HEADER:
- String headerParamId = argumentDef.paramId().map(id -> id.name()).orElse(argName.get());
+ String headerParamId = argumentDef.paramId().map(id -> id.name()).orElseGet(() -> argName.get());
return ParameterType.header(HeaderParameterType.of(ParameterId.of(headerParamId)));
case PATH:
return ParameterType.path(PathParameterType.of());
case BODY:
return ParameterType.body(BodyParameterType.of());
case QUERY:
- String queryParamId = argumentDef.paramId().map(id -> id.name()).orElse(argName.get());
+ String queryParamId = argumentDef.paramId().map(id -> id.name()).orElseGet(() -> argName.get());
return ParameterType.query(QueryParameterType.of(ParameterId.of(queryParamId)));
default:
throw new IllegalArgumentException("Unknown parameter type: " + argumentDef.paramType());
diff --git a/conjure-core/src/main/java/com/palantir/conjure/defs/ConjureTypeParserVisitor.java b/conjure-core/src/main/java/com/palantir/conjure/defs/ConjureTypeParserVisitor.java
index 2bb2cab75..b29889d10 100644
--- a/conjure-core/src/main/java/com/palantir/conjure/defs/ConjureTypeParserVisitor.java
+++ b/conjure-core/src/main/java/com/palantir/conjure/defs/ConjureTypeParserVisitor.java
@@ -105,7 +105,7 @@ public ConjureTypeParserVisitor(ReferenceTypeResolver nameResolver) {
}
@Override
- public Type visitAny(AnyType type) {
+ public Type visitAny(AnyType _type) {
return Type.primitive(com.palantir.conjure.spec.PrimitiveType.ANY);
}
@@ -146,12 +146,12 @@ public Type visitSet(SetType type) {
}
@Override
- public Type visitBinary(BinaryType type) {
+ public Type visitBinary(BinaryType _type) {
return Type.primitive(com.palantir.conjure.spec.PrimitiveType.BINARY);
}
@Override
- public Type visitDateTime(DateTimeType type) {
+ public Type visitDateTime(DateTimeType _type) {
return Type.primitive(com.palantir.conjure.spec.PrimitiveType.DATETIME);
}
}
diff --git a/conjure-core/src/main/java/com/palantir/conjure/defs/validator/ConjureDefinitionValidator.java b/conjure-core/src/main/java/com/palantir/conjure/defs/validator/ConjureDefinitionValidator.java
index cc3f79be2..53c090316 100644
--- a/conjure-core/src/main/java/com/palantir/conjure/defs/validator/ConjureDefinitionValidator.java
+++ b/conjure-core/src/main/java/com/palantir/conjure/defs/validator/ConjureDefinitionValidator.java
@@ -224,7 +224,7 @@ private static void validateTypeDefinition(TypeDefinition typeDef,
typeDef.accept(new TypeDefinition.Visitor() {
@Override
- public Void visitAlias(AliasDefinition value) {
+ public Void visitAlias(AliasDefinition _value) {
AliasDefinition aliasDef = typeDef.accept(TypeDefinitionVisitor.ALIAS);
if (recursivelyFindNestedOptionals(aliasDef.getAlias(), definitionMap, false)) {
throw new IllegalStateException(
@@ -234,7 +234,7 @@ public Void visitAlias(AliasDefinition value) {
}
@Override
- public Void visitObject(ObjectDefinition value) {
+ public Void visitObject(ObjectDefinition _value) {
ObjectDefinition objectDefinition = typeDef.accept(TypeDefinitionVisitor.OBJECT);
objectDefinition.getFields().stream()
.filter(fieldDefinition -> recursivelyFindNestedOptionals(
@@ -249,7 +249,7 @@ public Void visitObject(ObjectDefinition value) {
}
@Override
- public Void visitUnion(UnionDefinition value) {
+ public Void visitUnion(UnionDefinition _value) {
UnionDefinition unionDefinition = typeDef.accept(TypeDefinitionVisitor.UNION);
unionDefinition.getUnion().stream()
.filter(fieldDefinition -> recursivelyFindNestedOptionals(
@@ -264,12 +264,12 @@ public Void visitUnion(UnionDefinition value) {
}
@Override
- public Void visitEnum(EnumDefinition value) {
+ public Void visitEnum(EnumDefinition _value) {
return null;
}
@Override
- public Void visitUnknown(String unknownType) {
+ public Void visitUnknown(String _unknownType) {
return null;
}
});
diff --git a/conjure-core/src/main/java/com/palantir/conjure/defs/validator/EndpointDefinitionValidator.java b/conjure-core/src/main/java/com/palantir/conjure/defs/validator/EndpointDefinitionValidator.java
index c38fe80e3..8432046f7 100644
--- a/conjure-core/src/main/java/com/palantir/conjure/defs/validator/EndpointDefinitionValidator.java
+++ b/conjure-core/src/main/java/com/palantir/conjure/defs/validator/EndpointDefinitionValidator.java
@@ -39,6 +39,7 @@
import com.palantir.conjure.visitor.ParameterTypeVisitor;
import com.palantir.conjure.visitor.TypeDefinitionVisitor;
import com.palantir.conjure.visitor.TypeVisitor;
+import com.palantir.logsafe.exceptions.SafeRuntimeException;
import java.util.Arrays;
import java.util.HashSet;
import java.util.List;
@@ -298,25 +299,25 @@ public Boolean visitSet(SetType value) {
}
@Override
- public Boolean visitMap(MapType value) {
+ public Boolean visitMap(MapType _value) {
return false;
}
// The cases below should not be handled here, since they implicitly handled by the
// DealiasingTypeVisitor above
@Override
- public Boolean visitReference(TypeName value) {
- throw new RuntimeException("Unexpected type when validating query parameters");
+ public Boolean visitReference(TypeName _value) {
+ throw new SafeRuntimeException("Unexpected type when validating query parameters");
}
@Override
- public Boolean visitExternal(ExternalReference value) {
- throw new RuntimeException("Unexpected type when validating query parameters");
+ public Boolean visitExternal(ExternalReference _value) {
+ throw new SafeRuntimeException("Unexpected type when validating query parameters");
}
@Override
- public Boolean visitUnknown(String unknownType) {
- throw new RuntimeException("Unexpected type when validating query parameters");
+ public Boolean visitUnknown(String _unknownType) {
+ throw new SafeRuntimeException("Unexpected type when validating query parameters");
}
}));
}
diff --git a/conjure-core/src/main/java/com/palantir/conjure/defs/validator/UnionDefinitionValidator.java b/conjure-core/src/main/java/com/palantir/conjure/defs/validator/UnionDefinitionValidator.java
index 1acfe5b42..c5c40197a 100644
--- a/conjure-core/src/main/java/com/palantir/conjure/defs/validator/UnionDefinitionValidator.java
+++ b/conjure-core/src/main/java/com/palantir/conjure/defs/validator/UnionDefinitionValidator.java
@@ -74,7 +74,7 @@ private static boolean isValidJavaIdentifier(String key) {
@Override
public void validate(UnionDefinition definition) {
definition.getUnion().stream().forEach(fieldDef -> {
- Preconditions.checkArgument(!Strings.isNullOrEmpty(fieldDef.getFieldName().get()),
+ com.palantir.logsafe.Preconditions.checkArgument(!Strings.isNullOrEmpty(fieldDef.getFieldName().get()),
"Union member key must not be empty");
Preconditions.checkArgument(isValidJavaIdentifier(fieldDef.getFieldName().get()),
"Union member key must be a valid Java identifier: %s",
diff --git a/conjure-core/src/main/java/com/palantir/conjure/parser/services/ArgumentDefinition.java b/conjure-core/src/main/java/com/palantir/conjure/parser/services/ArgumentDefinition.java
index 772a35eab..9e5c63233 100644
--- a/conjure-core/src/main/java/com/palantir/conjure/parser/services/ArgumentDefinition.java
+++ b/conjure-core/src/main/java/com/palantir/conjure/parser/services/ArgumentDefinition.java
@@ -99,7 +99,7 @@ class Builder extends ImmutableArgumentDefinition.Builder {}
class ArgumentDefinitionDeserializer extends JsonDeserializer {
@SuppressWarnings("deprecation")
@Override
- public ArgumentDefinition deserialize(JsonParser parser, DeserializationContext context)
+ public ArgumentDefinition deserialize(JsonParser parser, DeserializationContext _context)
throws IOException, JsonProcessingException {
String candidate = parser.getValueAsString();
diff --git a/conjure-core/src/main/java/com/palantir/conjure/parser/services/AuthDefinition.java b/conjure-core/src/main/java/com/palantir/conjure/parser/services/AuthDefinition.java
index 2c767b10a..858da55dd 100644
--- a/conjure-core/src/main/java/com/palantir/conjure/parser/services/AuthDefinition.java
+++ b/conjure-core/src/main/java/com/palantir/conjure/parser/services/AuthDefinition.java
@@ -16,12 +16,12 @@
package com.palantir.conjure.parser.services;
-import static com.google.common.base.Preconditions.checkArgument;
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonValue;
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
import com.palantir.conjure.defs.ConjureImmutablesStyle;
+import com.palantir.logsafe.Preconditions;
import java.util.Locale;
import org.immutables.value.Value;
@@ -81,7 +81,7 @@ static AuthDefinition fromString(String value) {
id = "NONE";
break;
case COOKIE:
- checkArgument(parts.length == 2, "Cookie authorization type must include a cookie name");
+ Preconditions.checkArgument(parts.length == 2, "Cookie authorization type must include a cookie name");
id = parts[1];
break;
default:
diff --git a/conjure-core/src/main/java/com/palantir/conjure/parser/types/BaseObjectTypeDefinition.java b/conjure-core/src/main/java/com/palantir/conjure/parser/types/BaseObjectTypeDefinition.java
index 13479fcd5..d2ebad8c4 100644
--- a/conjure-core/src/main/java/com/palantir/conjure/parser/types/BaseObjectTypeDefinition.java
+++ b/conjure-core/src/main/java/com/palantir/conjure/parser/types/BaseObjectTypeDefinition.java
@@ -29,6 +29,7 @@
import com.palantir.conjure.parser.types.complex.UnionTypeDefinition;
import com.palantir.conjure.parser.types.names.ConjurePackage;
import com.palantir.conjure.parser.types.reference.AliasTypeDefinition;
+import com.palantir.logsafe.exceptions.SafeIllegalArgumentException;
import java.io.IOException;
import java.util.Optional;
@@ -44,7 +45,7 @@ public interface BaseObjectTypeDefinition {
class BaseObjectTypeDefinitionDeserializer extends JsonDeserializer {
@Override
- public BaseObjectTypeDefinition deserialize(JsonParser parser, DeserializationContext ctxt) throws IOException {
+ public BaseObjectTypeDefinition deserialize(JsonParser parser, DeserializationContext _ctxt) throws IOException {
TreeNode tree = parser.readValueAsTree();
if (tree.get("fields") != null) {
return ObjectTypeDefinition.fromJson(parser, tree);
@@ -57,7 +58,7 @@ public BaseObjectTypeDefinition deserialize(JsonParser parser, DeserializationCo
} else if (tree.get("namespace") != null) {
return ErrorTypeDefinition.fromJson(parser, tree);
} else {
- throw new IllegalArgumentException(
+ throw new SafeIllegalArgumentException(
"Unrecognized definition, types must have either fields, values or an alias defined.");
}
}
diff --git a/conjure-core/src/main/java/com/palantir/conjure/parser/types/TypeParser.java b/conjure-core/src/main/java/com/palantir/conjure/parser/types/TypeParser.java
index 171d5684e..0a28f9845 100644
--- a/conjure-core/src/main/java/com/palantir/conjure/parser/types/TypeParser.java
+++ b/conjure-core/src/main/java/com/palantir/conjure/parser/types/TypeParser.java
@@ -212,7 +212,7 @@ public T parse(ParserState input) throws ParseException {
return instance;
}
- public static TypeFromString of(String type, T instance, Class metric) {
+ public static TypeFromString of(String type, T instance, Class _metric) {
return new TypeFromString<>(type, instance);
}
}
diff --git a/conjure-core/src/main/java/com/palantir/conjure/parser/types/complex/EnumValueDefinition.java b/conjure-core/src/main/java/com/palantir/conjure/parser/types/complex/EnumValueDefinition.java
index 43040e281..128937995 100644
--- a/conjure-core/src/main/java/com/palantir/conjure/parser/types/complex/EnumValueDefinition.java
+++ b/conjure-core/src/main/java/com/palantir/conjure/parser/types/complex/EnumValueDefinition.java
@@ -44,7 +44,7 @@ class Builder extends ImmutableEnumValueDefinition.Builder {}
class EnumValueDeserializer extends JsonDeserializer {
@SuppressWarnings("deprecation")
@Override
- public EnumValueDefinition deserialize(JsonParser parser, DeserializationContext ctxt)
+ public EnumValueDefinition deserialize(JsonParser parser, DeserializationContext _ctxt)
throws IOException {
String candidate = parser.getValueAsString();
if (candidate != null) {
diff --git a/conjure-core/src/main/java/com/palantir/conjure/parser/types/complex/ErrorTypeDefinition.java b/conjure-core/src/main/java/com/palantir/conjure/parser/types/complex/ErrorTypeDefinition.java
index 36f5b962c..568684f28 100644
--- a/conjure-core/src/main/java/com/palantir/conjure/parser/types/complex/ErrorTypeDefinition.java
+++ b/conjure-core/src/main/java/com/palantir/conjure/parser/types/complex/ErrorTypeDefinition.java
@@ -46,7 +46,7 @@ public interface ErrorTypeDefinition extends BaseObjectTypeDefinition {
Map unsafeArgs();
@Override
- default T visit(TypeDefinitionVisitor visitor) {
+ default T visit(TypeDefinitionVisitor _visitor) {
throw new UnsupportedOperationException();
}
diff --git a/conjure-core/src/main/java/com/palantir/conjure/parser/types/complex/FieldDefinition.java b/conjure-core/src/main/java/com/palantir/conjure/parser/types/complex/FieldDefinition.java
index 2af098348..aebe6d680 100644
--- a/conjure-core/src/main/java/com/palantir/conjure/parser/types/complex/FieldDefinition.java
+++ b/conjure-core/src/main/java/com/palantir/conjure/parser/types/complex/FieldDefinition.java
@@ -45,7 +45,7 @@ static FieldDefinition of(ConjureType type) {
class FieldDefinitionDeserializer extends JsonDeserializer {
@SuppressWarnings("deprecation")
@Override
- public FieldDefinition deserialize(JsonParser parser, DeserializationContext context) throws IOException {
+ public FieldDefinition deserialize(JsonParser parser, DeserializationContext _context) throws IOException {
String candidate = parser.getValueAsString();
if (candidate != null) {
diff --git a/conjure-core/src/test/java/com/palantir/conjure/defs/ConjureDefTest.java b/conjure-core/src/test/java/com/palantir/conjure/defs/ConjureDefTest.java
index 47c560699..1d8e13d80 100644
--- a/conjure-core/src/test/java/com/palantir/conjure/defs/ConjureDefTest.java
+++ b/conjure-core/src/test/java/com/palantir/conjure/defs/ConjureDefTest.java
@@ -38,7 +38,6 @@ public void resolvesImportedAliases() {
@Test
@Ignore
public void handlesNonJavaExternalType() {
- ConjureDefinition conjureDefinition = ConjureParserUtils.parseConjureDef(
- ImmutableList.of(ConjureParser.parse(new File("src/test/resources/example-external-types.yml"))));
+
}
}
diff --git a/conjure-core/src/test/java/com/palantir/conjure/defs/ConjureSpecTest.java b/conjure-core/src/test/java/com/palantir/conjure/defs/ConjureSpecTest.java
index 80712fb80..be94910f8 100644
--- a/conjure-core/src/test/java/com/palantir/conjure/defs/ConjureSpecTest.java
+++ b/conjure-core/src/test/java/com/palantir/conjure/defs/ConjureSpecTest.java
@@ -69,7 +69,7 @@ public ConjureSpecTest(TestCaseDefinition testCaseDef) {
@Test
public void testConjureSpec() {
// test positive cases
- testCaseDef.positive().orElse(new TreeMap<>()).entrySet().stream().forEach(entry -> {
+ testCaseDef.positive().orElseGet(() -> new TreeMap<>()).entrySet().stream().forEach(entry -> {
String testName = String.format("positive case %s", entry.getKey());
String yml = getYmlAsString(testName, entry.getValue().conjure());
try {
@@ -80,7 +80,7 @@ public void testConjureSpec() {
});
// test negative cases
- testCaseDef.negative().orElse(new TreeMap<>()).entrySet().stream().forEach(entry -> {
+ testCaseDef.negative().orElseGet(() -> new TreeMap<>()).entrySet().stream().forEach(entry -> {
String testName = String.format("negative case %s", entry.getKey());
String yml = getYmlAsString(testName, entry.getValue().conjure());
try {
diff --git a/conjure-generator-common/src/main/java/com/palantir/conjure/either/Either.java b/conjure-generator-common/src/main/java/com/palantir/conjure/either/Either.java
index 294aff146..e37234127 100644
--- a/conjure-generator-common/src/main/java/com/palantir/conjure/either/Either.java
+++ b/conjure-generator-common/src/main/java/com/palantir/conjure/either/Either.java
@@ -39,7 +39,7 @@ abstract class Left implements Either {
abstract L value();
@Override
- public T fold(Function super L, ? extends T> mapLeft, Function super R, ? extends T> mapRight) {
+ public T fold(Function super L, ? extends T> mapLeft, Function super R, ? extends T> _mapRight) {
return mapLeft.apply(value());
}
}
@@ -50,7 +50,7 @@ abstract class Right implements Either {
abstract R value();
@Override
- public T fold(Function super L, ? extends T> mapLeft, Function super R, ? extends T> mapRight) {
+ public T fold(Function super L, ? extends T> _mapLeft, Function super R, ? extends T> mapRight) {
return mapRight.apply(value());
}
}
diff --git a/conjure-generator-common/src/main/java/com/palantir/conjure/visitor/AuthTypeVisitor.java b/conjure-generator-common/src/main/java/com/palantir/conjure/visitor/AuthTypeVisitor.java
index 886f61c6e..928cd1481 100644
--- a/conjure-generator-common/src/main/java/com/palantir/conjure/visitor/AuthTypeVisitor.java
+++ b/conjure-generator-common/src/main/java/com/palantir/conjure/visitor/AuthTypeVisitor.java
@@ -43,31 +43,31 @@ public CookieAuthType visitCookie(CookieAuthType value) {
private static class DefaultIsAuthTypeVisitor implements AuthType.Visitor {
@Override
- public Boolean visitHeader(HeaderAuthType value) {
+ public Boolean visitHeader(HeaderAuthType _value) {
return false;
}
@Override
- public Boolean visitCookie(CookieAuthType value) {
+ public Boolean visitCookie(CookieAuthType _value) {
return false;
}
@Override
- public Boolean visitUnknown(String unknownType) {
+ public Boolean visitUnknown(String _unknownType) {
return false;
}
}
private static class IsHeaderAuthTypeVisitor extends DefaultIsAuthTypeVisitor {
@Override
- public Boolean visitHeader(HeaderAuthType value) {
+ public Boolean visitHeader(HeaderAuthType _value) {
return true;
}
}
private static class IsCookieAuthTypeVisitor extends DefaultIsAuthTypeVisitor {
@Override
- public Boolean visitCookie(CookieAuthType value) {
+ public Boolean visitCookie(CookieAuthType _value) {
return true;
}
}
diff --git a/conjure-generator-common/src/main/java/com/palantir/conjure/visitor/ParameterTypeVisitor.java b/conjure-generator-common/src/main/java/com/palantir/conjure/visitor/ParameterTypeVisitor.java
index c804d6312..4f9f8b432 100644
--- a/conjure-generator-common/src/main/java/com/palantir/conjure/visitor/ParameterTypeVisitor.java
+++ b/conjure-generator-common/src/main/java/com/palantir/conjure/visitor/ParameterTypeVisitor.java
@@ -81,55 +81,55 @@ public PathParameterType visitPath(PathParameterType value) {
private static class IsParameterTypeVisitor implements ParameterType.Visitor {
@Override
- public Boolean visitBody(BodyParameterType value) {
+ public Boolean visitBody(BodyParameterType _value) {
return false;
}
@Override
- public Boolean visitHeader(HeaderParameterType value) {
+ public Boolean visitHeader(HeaderParameterType _value) {
return false;
}
@Override
- public Boolean visitPath(PathParameterType value) {
+ public Boolean visitPath(PathParameterType _value) {
return false;
}
@Override
- public Boolean visitQuery(QueryParameterType value) {
+ public Boolean visitQuery(QueryParameterType _value) {
return false;
}
@Override
- public Boolean visitUnknown(String unknownType) {
+ public Boolean visitUnknown(String _unknownType) {
return false;
}
}
private static class IsBodyParameterType extends IsParameterTypeVisitor {
@Override
- public Boolean visitBody(BodyParameterType value) {
+ public Boolean visitBody(BodyParameterType _value) {
return true;
}
}
private static class IsPathParameterType extends IsParameterTypeVisitor {
@Override
- public Boolean visitPath(PathParameterType value) {
+ public Boolean visitPath(PathParameterType _value) {
return true;
}
}
private static class IsHeaderParameterType extends IsParameterTypeVisitor {
@Override
- public Boolean visitHeader(HeaderParameterType value) {
+ public Boolean visitHeader(HeaderParameterType _value) {
return true;
}
}
private static class IsQueryParameterType extends IsParameterTypeVisitor {
@Override
- public Boolean visitQuery(QueryParameterType value) {
+ public Boolean visitQuery(QueryParameterType _value) {
return true;
}
}
diff --git a/conjure-generator-common/src/main/java/com/palantir/conjure/visitor/TypeDefinitionVisitor.java b/conjure-generator-common/src/main/java/com/palantir/conjure/visitor/TypeDefinitionVisitor.java
index 729f298c1..11c61c5c7 100644
--- a/conjure-generator-common/src/main/java/com/palantir/conjure/visitor/TypeDefinitionVisitor.java
+++ b/conjure-generator-common/src/main/java/com/palantir/conjure/visitor/TypeDefinitionVisitor.java
@@ -112,55 +112,55 @@ public T visitUnknown(String unknownType) {
private static class IsAliasDefinitionVisitor extends DefaultIsTypeDefinitionVisitor {
@Override
- public Boolean visitAlias(AliasDefinition value) {
+ public Boolean visitAlias(AliasDefinition _value) {
return true;
}
}
private static class IsObjectDefinitionVisitor extends DefaultIsTypeDefinitionVisitor {
@Override
- public Boolean visitObject(ObjectDefinition value) {
+ public Boolean visitObject(ObjectDefinition _value) {
return true;
}
}
private static class IsEnumDefinitionVisitor extends DefaultIsTypeDefinitionVisitor {
@Override
- public Boolean visitEnum(EnumDefinition value) {
+ public Boolean visitEnum(EnumDefinition _value) {
return true;
}
}
private static class IsUnionDefinitionVisitor extends DefaultIsTypeDefinitionVisitor {
@Override
- public Boolean visitUnion(UnionDefinition value) {
+ public Boolean visitUnion(UnionDefinition _value) {
return true;
}
}
private static class DefaultIsTypeDefinitionVisitor implements TypeDefinition.Visitor {
@Override
- public Boolean visitAlias(AliasDefinition value) {
+ public Boolean visitAlias(AliasDefinition _value) {
return false;
}
@Override
- public Boolean visitEnum(EnumDefinition value) {
+ public Boolean visitEnum(EnumDefinition _value) {
return false;
}
@Override
- public Boolean visitObject(ObjectDefinition value) {
+ public Boolean visitObject(ObjectDefinition _value) {
return false;
}
@Override
- public Boolean visitUnion(UnionDefinition value) {
+ public Boolean visitUnion(UnionDefinition _value) {
return false;
}
@Override
- public Boolean visitUnknown(String unknownType) {
+ public Boolean visitUnknown(String _unknownType) {
return false;
}
}
diff --git a/conjure-generator-common/src/main/java/com/palantir/conjure/visitor/TypeVisitor.java b/conjure-generator-common/src/main/java/com/palantir/conjure/visitor/TypeVisitor.java
index ba323b215..7a9373c02 100644
--- a/conjure-generator-common/src/main/java/com/palantir/conjure/visitor/TypeVisitor.java
+++ b/conjure-generator-common/src/main/java/com/palantir/conjure/visitor/TypeVisitor.java
@@ -37,64 +37,64 @@ private TypeVisitor() {}
private static class IsPrimitiveTypeVisitor extends IsTypeVisitor {
@Override
- public Boolean visitPrimitive(PrimitiveType value) {
+ public Boolean visitPrimitive(PrimitiveType _value) {
return true;
}
}
private static class IsOptionalTypeVisitor extends IsTypeVisitor {
@Override
- public Boolean visitOptional(OptionalType value) {
+ public Boolean visitOptional(OptionalType _value) {
return true;
}
}
private static class IsListTypeVisitor extends IsTypeVisitor {
@Override
- public Boolean visitList(ListType value) {
+ public Boolean visitList(ListType _value) {
return true;
}
}
private static class IsSetTypeVisitor extends IsTypeVisitor {
@Override
- public Boolean visitSet(SetType value) {
+ public Boolean visitSet(SetType _value) {
return true;
}
}
private static class IsMapTypeVisitor extends IsTypeVisitor {
@Override
- public Boolean visitMap(MapType value) {
+ public Boolean visitMap(MapType _value) {
return true;
}
}
private static class IsReferenceTypeVisitor extends IsTypeVisitor {
@Override
- public Boolean visitReference(TypeName value) {
+ public Boolean visitReference(TypeName _value) {
return true;
}
@Override
- public Boolean visitExternal(ExternalReference value) {
+ public Boolean visitExternal(ExternalReference _value) {
return true;
}
}
private static class IsPrimitiveOrReferenceType extends IsTypeVisitor {
@Override
- public Boolean visitPrimitive(PrimitiveType value) {
+ public Boolean visitPrimitive(PrimitiveType _value) {
return true;
}
@Override
- public Boolean visitReference(TypeName value) {
+ public Boolean visitReference(TypeName _value) {
return true;
}
@Override
- public Boolean visitExternal(ExternalReference value) {
+ public Boolean visitExternal(ExternalReference _value) {
return true;
}
}
@@ -115,42 +115,42 @@ public Boolean visitPrimitive(PrimitiveType value) {
private static class IsTypeVisitor implements Type.Visitor {
@Override
- public Boolean visitPrimitive(PrimitiveType value) {
+ public Boolean visitPrimitive(PrimitiveType _value) {
return false;
}
@Override
- public Boolean visitOptional(OptionalType value) {
+ public Boolean visitOptional(OptionalType _value) {
return false;
}
@Override
- public Boolean visitList(ListType value) {
+ public Boolean visitList(ListType _value) {
return false;
}
@Override
- public Boolean visitSet(SetType value) {
+ public Boolean visitSet(SetType _value) {
return false;
}
@Override
- public Boolean visitMap(MapType value) {
+ public Boolean visitMap(MapType _value) {
return false;
}
@Override
- public Boolean visitReference(TypeName value) {
+ public Boolean visitReference(TypeName _value) {
return false;
}
@Override
- public Boolean visitExternal(ExternalReference value) {
+ public Boolean visitExternal(ExternalReference _value) {
return false;
}
@Override
- public Boolean visitUnknown(String unknownType) {
+ public Boolean visitUnknown(String _unknownType) {
return false;
}
}
@@ -158,7 +158,7 @@ public Boolean visitUnknown(String unknownType) {
private static class DefaultTypeVisitor implements Type.Visitor {
@Override
- public T visitPrimitive(PrimitiveType value) {
+ public T visitPrimitive(PrimitiveType _value) {
return null;
}