From 2d19005d989d8737db5b68aaac0bf4a30e825559 Mon Sep 17 00:00:00 2001 From: Carter Kozak Date: Fri, 17 May 2024 17:22:47 -0400 Subject: [PATCH 1/2] CachingFallbackDnsResolver logs at debug level This can be fairly noisy, without providing much value at this point. --- .../dialogue/clients/CachingFallbackDnsResolver.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/dialogue-clients/src/main/java/com/palantir/dialogue/clients/CachingFallbackDnsResolver.java b/dialogue-clients/src/main/java/com/palantir/dialogue/clients/CachingFallbackDnsResolver.java index 1142c64b5..c846c9dc4 100644 --- a/dialogue-clients/src/main/java/com/palantir/dialogue/clients/CachingFallbackDnsResolver.java +++ b/dialogue-clients/src/main/java/com/palantir/dialogue/clients/CachingFallbackDnsResolver.java @@ -58,9 +58,11 @@ public ImmutableSet resolve(String hostname) { ImmutableSet maybeFallback = fallbackCache.getIfPresent(hostname); if (maybeFallback != null) { lookupFallback.mark(); - log.info( - "DNS resolution failed for host '{}', however fallback addresses are present in the cache", - UnsafeArg.of("hostname", hostname)); + if (log.isDebugEnabled()) { + log.debug( + "DNS resolution failed for host '{}', however fallback addresses are present in the cache", + UnsafeArg.of("hostname", hostname)); + } return maybeFallback; } else { lookupFailure.mark(); From c9a69f8e4cb5d30dcb29e6fc0dd8063849f0b1c1 Mon Sep 17 00:00:00 2001 From: svc-changelog Date: Fri, 17 May 2024 21:24:37 +0000 Subject: [PATCH 2/2] Add generated changelog entries --- changelog/@unreleased/pr-2283.v2.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelog/@unreleased/pr-2283.v2.yml diff --git a/changelog/@unreleased/pr-2283.v2.yml b/changelog/@unreleased/pr-2283.v2.yml new file mode 100644 index 000000000..39b2bf1ae --- /dev/null +++ b/changelog/@unreleased/pr-2283.v2.yml @@ -0,0 +1,5 @@ +type: improvement +improvement: + description: CachingFallbackDnsResolver logs at debug level + links: + - https://github.com/palantir/dialogue/pull/2283