New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Junit 5 extension #138

Closed
jcustenborder opened this Issue Jan 19, 2017 · 9 comments

Comments

Projects
None yet
6 participants
@jcustenborder

jcustenborder commented Jan 19, 2017

What are the thoughts about a junit 5 extension? I've done some work in a private repo that I could contribute.

@hpryce

This comment has been minimized.

Show comment
Hide comment
@hpryce

hpryce Jan 19, 2017

Collaborator

One of the things we've been thinking of is splitting the core of the library and the junit part into two separate projects. That way consumers can decide whether or not they want the junit (4) bindings or just want to get the raw classes for managing the lifecycle of a docker-compose cluster. If that happened we could really easily have a junit 5 project that independently added support. How does this sound? The project split should be relatively straightforward but I think needs changes to the bintray publishing so it would probably need to be done by me or @joelea.

Collaborator

hpryce commented Jan 19, 2017

One of the things we've been thinking of is splitting the core of the library and the junit part into two separate projects. That way consumers can decide whether or not they want the junit (4) bindings or just want to get the raw classes for managing the lifecycle of a docker-compose cluster. If that happened we could really easily have a junit 5 project that independently added support. How does this sound? The project split should be relatively straightforward but I think needs changes to the bintray publishing so it would probably need to be done by me or @joelea.

@joelea

This comment has been minimized.

Show comment
Hide comment
@joelea

joelea Jan 19, 2017

Contributor

@hpryce sounds like we should actually get round to it now.

@jcustenborder would you be happy maintaining the junit 5 bindings independently or would you want us to bring it under the umbrella of core + junit 5?

Contributor

joelea commented Jan 19, 2017

@hpryce sounds like we should actually get round to it now.

@jcustenborder would you be happy maintaining the junit 5 bindings independently or would you want us to bring it under the umbrella of core + junit 5?

@jcustenborder

This comment has been minimized.

Show comment
Hide comment
@jcustenborder

jcustenborder Jan 19, 2017

@hpryce That is what I was thinking. It would be great if the core docker-compose library was in another project. It's useful enough that it could easily be it's own project. Then I could pull it in for the JUnit 5 extension.

@joelea I'm open to hosting it under jcustenborder. The only weirdness is that I don't have any experience with bintray. I deploy to central.

jcustenborder commented Jan 19, 2017

@hpryce That is what I was thinking. It would be great if the core docker-compose library was in another project. It's useful enough that it could easily be it's own project. Then I could pull it in for the JUnit 5 extension.

@joelea I'm open to hosting it under jcustenborder. The only weirdness is that I don't have any experience with bintray. I deploy to central.

@joelea

This comment has been minimized.

Show comment
Hide comment
@joelea

joelea Jan 27, 2017

Contributor

@hpryce merged #140 which splits out the projects, but our publishing was slightly wrong. We'll fix that soon and then you should be able to do what you want with the "core" section.

Contributor

joelea commented Jan 27, 2017

@hpryce merged #140 which splits out the projects, but our publishing was slightly wrong. We'll fix that soon and then you should be able to do what you want with the "core" section.

@jcustenborder

This comment has been minimized.

Show comment
Hide comment
@jcustenborder

jcustenborder Jan 28, 2017

Thanks @joelea and @hpryce! Much appreciated!

jcustenborder commented Jan 28, 2017

Thanks @joelea and @hpryce! Much appreciated!

@joelea

This comment has been minimized.

Show comment
Hide comment
@joelea

joelea Feb 22, 2017

Contributor

@jcustenborder this split has now happened. It is very unlikely to have been split up perfectly to make this trivial. My thinking is that it would be best to implement a JUnit 5 version by copy pasting code from the JUnit 4 version when necessary, and then we can go through a process of deduplication once we figure out what the solution looks like.

Contributor

joelea commented Feb 22, 2017

@jcustenborder this split has now happened. It is very unlikely to have been split up perfectly to make this trivial. My thinking is that it would be best to implement a JUnit 5 version by copy pasting code from the JUnit 4 version when necessary, and then we can go through a process of deduplication once we figure out what the solution looks like.

@tobad357

This comment has been minimized.

Show comment
Hide comment
@tobad357

tobad357 Aug 25, 2017

@jcustenborder did you progress with the junit5 work
I'm interested in it as we need BeforeAll and AfterAll in junit5

I would be happy to help out if needed

@joelea has any work progressed anywhere else?

tobad357 commented Aug 25, 2017

@jcustenborder did you progress with the junit5 work
I'm interested in it as we need BeforeAll and AfterAll in junit5

I would be happy to help out if needed

@joelea has any work progressed anywhere else?

@c100k

This comment has been minimized.

Show comment
Hide comment
@c100k

c100k Oct 11, 2017

@tobad357 if you want to use it from now in one of your project, here is a small workaround to make it work waiting for a new release with Junit5 support : https://github.com/c100k/docker-compose-rule-with-junit5.

Not sure if it works at 100% in all cases but in mine it does the job.

c100k commented Oct 11, 2017

@tobad357 if you want to use it from now in one of your project, here is a small workaround to make it work waiting for a new release with Junit5 support : https://github.com/c100k/docker-compose-rule-with-junit5.

Not sure if it works at 100% in all cases but in mine it does the job.

@fryz

This comment has been minimized.

Show comment
Hide comment
@fryz

fryz Apr 23, 2018

Contributor

This looks like it was refiled at #224 and is being worked on in #223

Contributor

fryz commented Apr 23, 2018

This looks like it was refiled at #224 and is being worked on in #223

@fryz fryz closed this Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment