options options options #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 27, 2017 17:53
Documentalist accepts ICompilerOptions, passes to compiler internally. update compiler tests.
since these options are pretty important
since Documentalist.create is gone first two default to true!
update readme usagePreview: docs |
adidahiya
approved these changes
Mar 28, 2017
| * (This is distinct from whatever options you need to build your typings.) | ||
| * If omitted, the default compiler options are used. | ||
| */ | ||
| // HACK: using any to avoid duplicate typings issue with ts.CompilerOptions |
There was a problem hiding this comment.
what's the typings issue exactly?
There was a problem hiding this comment.
i think a mismatch in versions between typescript used here and typescript used in ts-quick-docs, but i didn't look closely. it was one of those "definitions of X and X are not the same" (but they are).
themadcreator
approved these changes
Mar 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add options to compiler and typescript plugin. documentalist passes its options straight to compiler.
swap order of
Documentalistconstructor args so no need for empty plugins array every time.Documentalist.create()because they have options that will want to be set.