From c795723f89621663e7c46d0bd56fecb5e686bda8 Mon Sep 17 00:00:00 2001 From: forozco Date: Tue, 24 Sep 2019 17:35:29 -0400 Subject: [PATCH 1/2] disable unused variable --- .../groovy/com/palantir/baseline/plugins/BaselineErrorProne.java | 1 + 1 file changed, 1 insertion(+) diff --git a/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineErrorProne.java b/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineErrorProne.java index a673975b7..c70ba9eaf 100644 --- a/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineErrorProne.java +++ b/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineErrorProne.java @@ -180,6 +180,7 @@ private static void configureErrorProneOptions( errorProneOptions.setDisableWarningsInGeneratedCode(true); errorProneOptions.setExcludedPaths( String.format("%s/(build|src/generated.*)/.*", project.getProjectDir().getPath())); + errorProneOptions.check("UnusedVariable", CheckSeverity.OFF); errorProneOptions.check("EqualsHashCode", CheckSeverity.ERROR); errorProneOptions.check("EqualsIncompatibleType", CheckSeverity.ERROR); errorProneOptions.check("StreamResourceLeak", CheckSeverity.ERROR); From fc7e877bb4da4b4dffa7a32bb09af0f9ae6a8efe Mon Sep 17 00:00:00 2001 From: forozco Date: Tue, 24 Sep 2019 21:35:29 +0000 Subject: [PATCH 2/2] Add generated changelog entries --- changelog/@unreleased/pr-888.v2.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelog/@unreleased/pr-888.v2.yml diff --git a/changelog/@unreleased/pr-888.v2.yml b/changelog/@unreleased/pr-888.v2.yml new file mode 100644 index 000000000..d9ed98c94 --- /dev/null +++ b/changelog/@unreleased/pr-888.v2.yml @@ -0,0 +1,5 @@ +type: improvement +improvement: + description: Disable `UnusedVariable` error prone rule by default + links: + - https://github.com/palantir/gradle-baseline/pull/888