dockerComposeUp task #186
dockerComposeUp task #186
Conversation
| import org.gradle.api.tasks.TaskAction | ||
|
|
||
| @Slf4j | ||
| class DockerComposeUp extends DefaultTask { |
There was a problem hiding this comment.
Could we extend from an Exec task so that people can configure/override more stuff?
There was a problem hiding this comment.
Is there best practices regarding defining a task in a separate groovy class vs directly in the plugin class? We do the latter in PalantirDockerPlugin although a separate class makes things cleaner.
There was a problem hiding this comment.
Separate class is generally the way to go as it's much easier to add clear annotations for incremental behaviour, description etc etc.
It's also much easier to convert the separate classes from Groovy -> Java and gradle recommend writing plugins in Java over groovy https://docs.gradle.org/current/userguide/custom_plugins.html
There was a problem hiding this comment.
Best practice is to not extend Exec.
There was a problem hiding this comment.
OK fair enough, this will probably be fine as an MVP anyway - can always add more configurability if people really need it later
There was a problem hiding this comment.
Yeah - I would say composition with project.exec provides way more flexibility than directly extending Exec since you're bound to execs TaskAction method.
| when: | ||
| with('dockerComposeUp').build() | ||
| then: | ||
| file("foobarbaz").exists() |
There was a problem hiding this comment.
Yeah thanks for this - was infinitely better than what I'd done first.
| @@ -137,4 +137,41 @@ class DockerComposePluginTests extends AbstractPluginTest { | |||
| then: | |||
| buildResult.output.contains("Could not find specified template file") | |||
| } | |||
|
|
|||
| def 'docker-compose is executed and fails on invalid file'() { | |||
There was a problem hiding this comment.
Add a test specifiying a different docker-compose file
| hello: | ||
| container_name: "helloworld" | ||
| image: "python:3.4-alpine" | ||
| command: touch /test/foobarbaz |
There was a problem hiding this comment.
This can probably just be the alpine image (no python needed)
|
Directionally, I'd prefer to move this plugin back to towards its original intent: to create Docker images. Docker CLI wrapping seems like a bottomless endeavor, see some of the other issues on this repo. |
|
In agreement with Rob. Longer term should break out the build orchestration utility tasks somewhere else. |
|
Also in agreement about avoiding Docker CLI wrapping. The Covnersely, I think adding Docker Compose tasks is valuable and less prone to feature creep. The |
| @@ -152,6 +152,10 @@ replaces all occurrences of version variables of the form `{{group:name}}` in | |||
| the `docker-compose.yml.template` file by the resolved versions and writes the | |||
| resulting file as `docker-compose.yml`. | |||
|
|
|||
| The `docker-compose` plugin also provides a `dockerComposeUp` task that starts | |||
| the docker images specified in the `dockerComposeFile` in detached mode. | |||
There was a problem hiding this comment.
Also add the dockerComposeUp task to the list of tasks at the bottom of the README
No description provided.