PanZoom: Expose Zoom and Pan Api #3146

Merged
merged 3 commits into from Jan 5, 2017

Projects

None yet

4 participants

@CalvinFernandez
Collaborator

Expose pan and zoom api to allow users to imperatively pan and
zoom the chart independently of the mousewheel or pinch events.

closes #3141

Calvin Fernandez PanZoom: Expose Zoom and Pan Api
Expose pan and zoom api to allow users to imperatively pan and
zoom the chart independently of the mousewheel or pinch events.

closes #3141
40e4506
@CalvinFernandez CalvinFernandez added this to the v2.6.0 milestone Jan 5, 2017
@themadcreator

Conflicts incoming

+ *
+ * @param {Plottable.Point} [translateAmount] The amount by which to translate the x and y scales.
+ */
+ public pan(translateAmount: Plottable.Point) {
@themadcreator
themadcreator Jan 5, 2017 Collaborator

I think this is going to conflict with the changes I made to enable pan/zoom on category scales. So, can we wait until that other is merged? I can pull this down and update the PR once it's merged.

@CalvinFernandez
CalvinFernandez Jan 5, 2017 Collaborator

yep noticed major conflicts -- I'm totally fine waiting

themadcreator added some commits Jan 5, 2017
@themadcreator themadcreator Merging TransformableScale changes ff4c1c5
@themadcreator themadcreator Rename TransformableScale methods to pan/zoom
39069f4
@CalvinFernandez CalvinFernandez merged commit 6ff9285 into develop Jan 5, 2017

3 checks passed

cla/palantir CLA signed via membership in "palantir"
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@CalvinFernandez CalvinFernandez deleted the cfernandez/panZoomAPI branch Jan 6, 2017
@hellochar hellochar modified the milestone: v2.7.0, v2.6.0 Jan 9, 2017
@contra
contra commented Jan 10, 2017

Are there any docs live for this yet? Couldn't find any.

@CalvinFernandez
Collaborator

@contra working on this now sorry for the delay

@contra
contra commented Jan 13, 2017

@CalvinFernandez No prob, just wondering if I was missing something - I thought the docs were autogenerated from the source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment