-
Notifications
You must be signed in to change notification settings - Fork 19
Implement helpers for TagTranslator ease of use #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| type: improvement | ||
| improvement: | ||
| description: TagTranslator quality of life improvements | ||
| links: | ||
| - https://github.com/palantir/tracing-java/pull/717 |
49 changes: 49 additions & 0 deletions
49
tracing/src/main/java/com/palantir/tracing/CompositeTagTranslator.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /* | ||
| * (c) Copyright 2021 Palantir Technologies Inc. All rights reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.palantir.tracing; | ||
|
|
||
| import com.palantir.logsafe.Preconditions; | ||
|
|
||
| /** | ||
| * Default implementation of {@link TagTranslator} used by {@link TagTranslator#andThen(TagTranslator)}. | ||
| */ | ||
| final class CompositeTagTranslator<S> implements TagTranslator<S> { | ||
|
|
||
| private final TagTranslator<? super S> first; | ||
| private final TagTranslator<? super S> second; | ||
|
|
||
| CompositeTagTranslator(TagTranslator<? super S> first, TagTranslator<? super S> second) { | ||
| this.first = Preconditions.checkNotNull(first, "First TagTranslator is required"); | ||
| this.second = Preconditions.checkNotNull(second, "Second TagTranslator is required"); | ||
| } | ||
|
|
||
| @Override | ||
| public <T> void translate(TagAdapter<T> adapter, T target, S data) { | ||
| first.translate(adapter, target, data); | ||
| second.translate(adapter, target, data); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isEmpty(S data) { | ||
| return first.isEmpty(data) && second.isEmpty(data); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "CompositeTagTranslator{first=" + first + ", second=" + second + '}'; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
tracing/src/test/java/com/palantir/tracing/TagTranslatorTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /* | ||
| * (c) Copyright 2021 Palantir Technologies Inc. All rights reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.palantir.tracing; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| import java.util.Map; | ||
| import java.util.concurrent.atomic.AtomicInteger; | ||
| import org.junit.Test; | ||
|
|
||
| public class TagTranslatorTest { | ||
|
|
||
| @Test | ||
| public void testCombine() { | ||
| AtomicInteger stringTranslatorCalled = new AtomicInteger(); | ||
| TagTranslator<String> translator1 = new TagTranslator<String>() { | ||
| @Override | ||
| public <T> void translate(TagAdapter<T> _adapter, T _target, String _data) { | ||
| stringTranslatorCalled.incrementAndGet(); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isEmpty(String data) { | ||
| return data.isEmpty(); | ||
| } | ||
| }; | ||
| TagTranslator<String> combined = translator1.andThen(NoTagTranslator.INSTANCE); | ||
| assertThat(combined.isEmpty("")).isTrue(); | ||
| combined.translate(NopTagAdapter.INSTANCE, NopTagAdapter.INSTANCE, "value"); | ||
| assertThat(stringTranslatorCalled).hasValue(1); | ||
| } | ||
|
|
||
| private enum NopTagAdapter implements TagTranslator.TagAdapter<NopTagAdapter> { | ||
| INSTANCE; | ||
|
|
||
| @Override | ||
| public void tag(NopTagAdapter _target, String _key, String _value) {} | ||
|
|
||
| @Override | ||
| public void tag(NopTagAdapter _target, Map<String, String> _tags) {} | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this will all get inlined nicely