Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Add snake_case option for file-name-casing rule #4081

Merged
merged 2 commits into from Aug 1, 2018

Conversation

oleg-codaio
Copy link
Contributor

@oleg-codaio oleg-codaio commented Jul 30, 2018

Overview of change:

Adds an option to enforce snake-cased filenames (follow-up to #3434).

Fixes #4088

CHANGELOG.md entry:

[new-rule-option]: "snake-case" in "file-name-casing"

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @vaskevich! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link

@giladgray giladgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaskevich code looks perfect!! but please add tests for this. should be easy to copy the tests for kebab-case.

@oleg-codaio
Copy link
Contributor Author

Sure, done.

Copy link

@giladgray giladgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@giladgray giladgray merged commit 8603273 into palantir:master Aug 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants