Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed parenthesis bodies for one-line promise-function-async functions #4765

Conversation

@JoshuaKGoldberg
Copy link
Collaborator

commented Jun 15, 2019

PR checklist

  • Addresses an existing issue: fixes #4757
  • New feature, bugfix, or enhancement
    • Includes tests
  • [ ] Documentation update

Overview of change:

Allows bodies of arrow methods to be any depths of parenthesis.

[bugfix] allowed parenthesis in ignored promise-function-async single-line arrow functions

@adidahiya

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

image

@JoshuaKGoldberg

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 18, 2019

Will fix ..

Gets me every time...
@JoshuaKGoldberg

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 27, 2019

This new testNext failure is unrelated. #4812.

@JoshuaKGoldberg JoshuaKGoldberg merged commit af24731 into palantir:master Jul 27, 2019
13 of 14 checks passed
13 of 14 checks passed
ci/circleci: testNext Your tests failed on CircleCI
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: checkout-code Your tests passed on CircleCI!
Details
ci/circleci: clean-lockfile Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test2.1 Your tests passed on CircleCI!
Details
ci/circleci: test2.4 Your tests passed on CircleCI!
Details
ci/circleci: test2.7 Your tests passed on CircleCI!
Details
ci/circleci: test2.8 Your tests passed on CircleCI!
Details
ci/circleci: test2.9 Your tests passed on CircleCI!
Details
ci/circleci: test3.0 Your tests passed on CircleCI!
Details
ci/circleci: testRc Your tests passed on CircleCI!
Details
cla/palantir CLA signed on 2016-09-27 18:34 UTC+00:00
Details
@adidahiya adidahiya referenced this pull request Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.