Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new-rule-option] Introduce new typedef rule option (variable-declaration-ignore-function) #4769

Merged
merged 5 commits into from Jul 4, 2019

Conversation

@michaelw85
Copy link
Contributor

commented Jun 18, 2019

PR checklist

  • New feature #2654
    • Includes tests
  • Documentation update

Overview of change:

Add new option for typedef rule.
Ignores typedef requirement for vars for arrow and non arrow functions.

CHANGELOG.md entry:

[new-rule-option] typedef new option: variable-declaration-ignore-function

Ignores typedef requirement for vars for arrow and non arrow functions.

Fixes: #2654
@palantirtech

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

Thanks for your interest in palantir/tslint, @michaelw85! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

michaelw85 added 3 commits Jun 18, 2019
@michaelw85

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2019

@JoshuaKGoldberg Could you review this PR or do you know anyone who would be able to?

@JoshuaKGoldberg

This comment has been minimized.

Copy link
Collaborator

commented Jun 24, 2019

Hi yes, sorry for the delay! I will soon 🙂.

For context, both adidahiya and I are maintaining TSLint in roughly part time amounts. There's also a lot of ongoing work for migrating to ESLint. So this might take a few days more.

@michaelw85

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2019

@JoshuaKGoldberg Thanks for the reply. Don't worry there is no rush (for me) although I would definitely be happy to have this feature. I wasn't sure if anyone noticed the PR so I thought I would tag you since you categorized the linked feature request.

Copy link
Collaborator

left a comment

Source code looks good to me! Just waiting on test changes.

@michaelw85

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

@JoshuaKGoldberg PR is updated! Thanks for reviewing.

Copy link
Collaborator

left a comment

LGTM, thanks for the PR @michaelw85!

@JoshuaKGoldberg

This comment has been minimized.

Copy link
Collaborator

commented Jul 4, 2019

testNext failures are unrelated; will file a separate issue.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 1d5d624 into palantir:master Jul 4, 2019
13 of 14 checks passed
13 of 14 checks passed
ci/circleci: testNext Your tests failed on CircleCI
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: checkout-code Your tests passed on CircleCI!
Details
ci/circleci: clean-lockfile Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test2.1 Your tests passed on CircleCI!
Details
ci/circleci: test2.4 Your tests passed on CircleCI!
Details
ci/circleci: test2.7 Your tests passed on CircleCI!
Details
ci/circleci: test2.8 Your tests passed on CircleCI!
Details
ci/circleci: test2.9 Your tests passed on CircleCI!
Details
ci/circleci: test3.0 Your tests passed on CircleCI!
Details
ci/circleci: testRc Your tests passed on CircleCI!
Details
cla/palantir CLA signed on 2019-06-18 09:54 UTC+00:00
Details
@michaelw85 michaelw85 deleted the michaelw85:2654_arrow_func_typedef branch Jul 4, 2019
@adidahiya adidahiya referenced this pull request Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.