Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-async-without-await: check type property and add tests #4782

Merged

Conversation

@tanmoyopenroot
Copy link
Contributor

commented Jul 2, 2019

PR checklist

  • Addresses an existing issue: fixes #4773
  • New feature, bugfix, or enhancement
  • Includes tests
  • Documentation update

Overview of change:

Check for if node.type property exists when node.body is undefined

@JoshuaKGoldberg JoshuaKGoldberg changed the title check type property and add tests no-async-without-await: check type property and add tests Jul 4, 2019
Copy link
Collaborator

left a comment

LGTM, thanks so much for the bugfix and excellent tests @tanmoyopenroot! 🙌

@JoshuaKGoldberg JoshuaKGoldberg merged commit 8056e63 into palantir:master Jul 4, 2019
14 checks passed
14 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: checkout-code Your tests passed on CircleCI!
Details
ci/circleci: clean-lockfile Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test2.1 Your tests passed on CircleCI!
Details
ci/circleci: test2.4 Your tests passed on CircleCI!
Details
ci/circleci: test2.7 Your tests passed on CircleCI!
Details
ci/circleci: test2.8 Your tests passed on CircleCI!
Details
ci/circleci: test2.9 Your tests passed on CircleCI!
Details
ci/circleci: test3.0 Your tests passed on CircleCI!
Details
ci/circleci: testNext Your tests passed on CircleCI!
Details
ci/circleci: testRc Your tests passed on CircleCI!
Details
cla/palantir CLA signed on 2019-06-25 06:29 UTC+00:00
Details
@adidahiya adidahiya referenced this pull request Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.