Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strict comparison false positive #4786

Conversation

@tanmoyopenroot
Copy link
Contributor

commented Jul 6, 2019

PR checklist

  • Addresses an existing issue: fixes #4774
  • New feature, bugfix, or enhancement
  • Includes tests
  • Documentation update

Overview of change:

check if rightType or leftType in Binary Expression contains null or undefined.

Copy link
Collaborator

left a comment

Super, thanks @tanmoyopenroot! 🙌

@JoshuaKGoldberg JoshuaKGoldberg merged commit 1e48ae7 into palantir:master Jul 16, 2019
13 of 14 checks passed
13 of 14 checks passed
ci/circleci: testNext Your tests failed on CircleCI
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: checkout-code Your tests passed on CircleCI!
Details
ci/circleci: clean-lockfile Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test2.1 Your tests passed on CircleCI!
Details
ci/circleci: test2.4 Your tests passed on CircleCI!
Details
ci/circleci: test2.7 Your tests passed on CircleCI!
Details
ci/circleci: test2.8 Your tests passed on CircleCI!
Details
ci/circleci: test2.9 Your tests passed on CircleCI!
Details
ci/circleci: test3.0 Your tests passed on CircleCI!
Details
ci/circleci: testRc Your tests passed on CircleCI!
Details
cla/palantir CLA signed on 2019-06-25 06:29 UTC+00:00
Details
@dosentmatter dosentmatter referenced this pull request Jul 19, 2019
3 of 4 tasks complete
@adidahiya adidahiya referenced this pull request Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.