Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed new 'AsyncGenerator' name for await-promise async iterables #4800

Merged
merged 1 commit into from Jul 24, 2019

Conversation

@JoshuaKGoldberg
Copy link
Collaborator

commented Jul 16, 2019

PR checklist

  • Addresses an existing issue: fixes #4784
  • New feature, bugfix, or enhancement
    • Includes tests
  • [ ] Documentation update

Overview of change:

Allows the new AsyncGenerator type introduced in microsoft/TypeScript#30790 as one of the hardcoded names for async iterables.

Is there anything you'd like reviewers to focus on?

Is this the right approach? I think so, but 馃し鈥嶁檪 hard to tell with these kind-of-sort-of breaking changes.

CHANGELOG.md entry:

@adidahiya adidahiya merged commit 2947925 into palantir:master Jul 24, 2019
9 checks passed
9 checks passed
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test2.1 Your tests passed on CircleCI!
Details
ci/circleci: test2.4 Your tests passed on CircleCI!
Details
ci/circleci: test2.7 Your tests passed on CircleCI!
Details
ci/circleci: test2.8 Your tests passed on CircleCI!
Details
ci/circleci: test2.9 Your tests passed on CircleCI!
Details
ci/circleci: testNext Your tests passed on CircleCI!
Details
cla/palantir CLA signed on 2016-09-27 18:34 UTC+00:00
Details
@JoshuaKGoldberg JoshuaKGoldberg deleted the JoshuaKGoldberg:ts-next-async-generator branch Jul 24, 2019
@adidahiya adidahiya referenced this pull request Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.