Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add option to enforce alphabetical ordering regardless of blank lines #4808

Merged
merged 2 commits into from Jul 25, 2019

Conversation

@vedadeepta
Copy link
Contributor

commented Jul 24, 2019

PR checklist

  • Addresses an existing issue: fixes #4756
  • New feature, bugfix, or enhancement
  • Includes tests
  • Documentation update

Overview of change:

Added a option allow-blank-lines to rule object-literal-sort-keys which enforces alphabetical ordering regardless of blank lines between key/value pairs.

Is there anything you'd like reviewers to focus on?

Not sure if the option name allow-blank-lines is correct.

CHANGELOG.md entry:

[new-rule-option] ignore-blank-lines option for object-literal-sort-keys rule

@vedadeepta vedadeepta changed the title fix: add option to enfore alphabetical ordering regarding of blank lines fix: add option to enfore alphabetical ordering regardless of blank lines Jul 24, 2019
@vedadeepta vedadeepta changed the title fix: add option to enfore alphabetical ordering regardless of blank lines fix: add option to enforce alphabetical ordering regardless of blank lines Jul 24, 2019
Copy link
Member

left a comment

looks good, but let's call the option "ignore-blank-lines"

@adidahiya adidahiya merged commit 9924e7a into palantir:master Jul 25, 2019
13 of 14 checks passed
13 of 14 checks passed
ci/circleci: testNext Your tests failed on CircleCI
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: checkout-code Your tests passed on CircleCI!
Details
ci/circleci: clean-lockfile Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test2.1 Your tests passed on CircleCI!
Details
ci/circleci: test2.4 Your tests passed on CircleCI!
Details
ci/circleci: test2.7 Your tests passed on CircleCI!
Details
ci/circleci: test2.8 Your tests passed on CircleCI!
Details
ci/circleci: test2.9 Your tests passed on CircleCI!
Details
ci/circleci: test3.0 Your tests passed on CircleCI!
Details
ci/circleci: testRc Your tests passed on CircleCI!
Details
cla/palantir CLA signed on 2019-06-27 13:26 UTC+00:00
Details
@adidahiya adidahiya referenced this pull request Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.