Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add bigint support to restrict-plus-operand rule #4814

Merged

Conversation

@vedadeepta
Copy link
Contributor

commented Jul 27, 2019

PR checklist

  • Addresses an existing issue: fixes #4741
  • New feature, bugfix, or enhancement
  • Includes tests
  • Documentation update

Overview of change:

Add support for bigint in restrict-plus-operand rule. Checks if the node type is equal ts.TypeFlags.BigInt or ts.TypeFlags.BigIntLiteral.

Is there anything you'd like reviewers to focus on?

Maybe make this optional because bigint is not supported below typescript 3.2 and is not supported for javascript target es2017 & below. More on this typscript caveats.

CHANGELOG.md entry:

[enhancement] add BigInt support to restrict-plus-operands rule

Copy link
Member

left a comment

no, this doesn't need to be optional behavior, lgtm, thanks

@adidahiya adidahiya merged commit e17ea57 into palantir:master Jul 30, 2019
13 of 14 checks passed
13 of 14 checks passed
ci/circleci: testNext Your tests failed on CircleCI
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: checkout-code Your tests passed on CircleCI!
Details
ci/circleci: clean-lockfile Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test2.1 Your tests passed on CircleCI!
Details
ci/circleci: test2.4 Your tests passed on CircleCI!
Details
ci/circleci: test2.7 Your tests passed on CircleCI!
Details
ci/circleci: test2.8 Your tests passed on CircleCI!
Details
ci/circleci: test2.9 Your tests passed on CircleCI!
Details
ci/circleci: test3.0 Your tests passed on CircleCI!
Details
ci/circleci: testRc Your tests passed on CircleCI!
Details
cla/palantir CLA signed on 2019-06-27 13:26 UTC+00:00
Details
@adidahiya adidahiya referenced this pull request Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.