Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4746: fix weird failures in strict-boolean-expressions for 'ignore-rhs' option #4833

Conversation

@tanmoyopenroot
Copy link
Contributor

commented Aug 21, 2019

PR checklist

  • Addresses an existing issue: fixes #4746
  • bugfix
  • Includes tests
  • Documentation update

Overview of change:

check expression only if left node is not a BooleanBinaryExpression

CHANGELOG.md entry:

[bugfix] fix strict-boolean-expressions false positive with "ignore-rhs" option

Copy link
Collaborator

left a comment

LGTM, thanks for the fix @tanmoyopenroot!

@JoshuaKGoldberg

This comment has been minimized.

Copy link
Collaborator

commented Aug 25, 2019

Failures in testNext and testRc are unrelated.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 85d4125 into palantir:master Aug 25, 2019
12 of 14 checks passed
12 of 14 checks passed
ci/circleci: testNext Your tests failed on CircleCI
Details
ci/circleci: testRc Your tests failed on CircleCI
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: checkout-code Your tests passed on CircleCI!
Details
ci/circleci: clean-lockfile Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test2.1 Your tests passed on CircleCI!
Details
ci/circleci: test2.4 Your tests passed on CircleCI!
Details
ci/circleci: test2.7 Your tests passed on CircleCI!
Details
ci/circleci: test2.8 Your tests passed on CircleCI!
Details
ci/circleci: test2.9 Your tests passed on CircleCI!
Details
ci/circleci: test3.0 Your tests passed on CircleCI!
Details
cla/palantir CLA signed on 2019-06-25 06:29 UTC+00:00
Details
@adidahiya adidahiya referenced this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.