Skip to content
This repository has been archived by the owner. It is now read-only.

4746: fix weird failures in strict-boolean-expressions for 'ignore-rhs' option #4833

Conversation

tanmoyopenroot
Copy link
Contributor

@tanmoyopenroot tanmoyopenroot commented Aug 21, 2019

PR checklist

Overview of change:

check expression only if left node is not a BooleanBinaryExpression

CHANGELOG.md entry:

[bugfix] fix strict-boolean-expressions false positive with "ignore-rhs" option

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

LGTM, thanks for the fix @tanmoyopenroot!

@JoshuaKGoldberg
Copy link
Contributor

JoshuaKGoldberg commented Aug 25, 2019

Failures in testNext and testRc are unrelated.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 85d4125 into palantir:master Aug 25, 2019
12 of 14 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"ignore-rhs" causes weird failures
2 participants