Skip to content
This repository has been archived by the owner. It is now read-only.

Fix bug where the strict ts flag wasn't recognised correctly by no-unnecessary-type-assertion #4841

Merged
merged 3 commits into from Aug 31, 2019

Conversation

guidsdo
Copy link
Contributor

@guidsdo guidsdo commented Aug 26, 2019

This commit fixes #4840

PR checklist

Overview of change:

Fixed simple bug.

Is there anything you'd like reviewers to focus on?

Nope.

CHANGELOG.md entry:

[bugfix] fix no-unnecessary-type-assertion no error when "strict": true in compiler flags

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Looks great! One quick change, if you don't mind 🙏.

src/rules/noUnnecessaryTypeAssertionRule.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Thanks @guidsdo!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 44947c5 into palantir:master Aug 31, 2019
14 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule no-unnecessary-type-assertion doesn't work if tsconfig has "strict": true
2 participants