Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where the strict ts flag wasn't recognised correctly by `no-unnecessary-type-assertion` #4841

Merged
merged 3 commits into from Aug 31, 2019

Conversation

@guidsdo
Copy link
Contributor

commented Aug 26, 2019

This commit fixes #4840

PR checklist

  • Addresses an existing issue: fixes #4840
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

Fixed simple bug.

Is there anything you'd like reviewers to focus on?

Nope.

CHANGELOG.md entry:

[bugfix] fix no-unnecessary-type-assertion no error when "strict": true in compiler flags

Copy link
Collaborator

left a comment

Looks great! One quick change, if you don't mind 🙏.

src/rules/noUnnecessaryTypeAssertionRule.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

left a comment

Thanks @guidsdo!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 44947c5 into palantir:master Aug 31, 2019
14 checks passed
14 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: checkout-code Your tests passed on CircleCI!
Details
ci/circleci: clean-lockfile Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test2.1 Your tests passed on CircleCI!
Details
ci/circleci: test2.4 Your tests passed on CircleCI!
Details
ci/circleci: test2.7 Your tests passed on CircleCI!
Details
ci/circleci: test2.8 Your tests passed on CircleCI!
Details
ci/circleci: test2.9 Your tests passed on CircleCI!
Details
ci/circleci: test3.0 Your tests passed on CircleCI!
Details
ci/circleci: testNext Your tests passed on CircleCI!
Details
ci/circleci: testRc Your tests passed on CircleCI!
Details
cla/palantir CLA signed on 2019-07-10 13:21 UTC+00:00
Details
@adidahiya adidahiya referenced this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.