Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support granular config in 'object-literal-shorthand' #4842

Merged

Conversation

@pablobirukov
Copy link
Contributor

commented Aug 28, 2019

PR checklist

  • Addresses an existing issue: fixes #3778
  • Enhancement
    • Includes tests

Overview of change:

Support granular configuration in object-literal-shorthand

CHANGELOG.md entry:

[new-rule-option] object-literal-shorthand supports {"property"?: "never", "method"?: "never"} as config options

@pablobirukov pablobirukov force-pushed the evolution-gaming:improve-object-shorthand-2 branch from a7820f8 to 0fc8f6a Aug 28, 2019
@pablobirukov pablobirukov referenced this pull request Aug 28, 2019
3 of 3 tasks complete
src/rules/objectLiteralShorthandRule.ts Outdated Show resolved Hide resolved
src/rules/objectLiteralShorthandRule.ts Outdated Show resolved Hide resolved
src/rules/objectLiteralShorthandRule.ts Outdated Show resolved Hide resolved
src/rules/objectLiteralShorthandRule.ts Outdated Show resolved Hide resolved
src/rules/objectLiteralShorthandRule.ts Outdated Show resolved Hide resolved
@pablobirukov pablobirukov force-pushed the evolution-gaming:improve-object-shorthand-2 branch from 3aec0d5 to e4b4123 Sep 5, 2019
Copy link
Member

left a comment

thanks for the PR!

@adidahiya adidahiya merged commit 0f2a540 into palantir:master Sep 5, 2019
14 checks passed
14 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: checkout-code Your tests passed on CircleCI!
Details
ci/circleci: clean-lockfile Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test2.1 Your tests passed on CircleCI!
Details
ci/circleci: test2.4 Your tests passed on CircleCI!
Details
ci/circleci: test2.7 Your tests passed on CircleCI!
Details
ci/circleci: test2.8 Your tests passed on CircleCI!
Details
ci/circleci: test2.9 Your tests passed on CircleCI!
Details
ci/circleci: test3.0 Your tests passed on CircleCI!
Details
ci/circleci: testNext Your tests passed on CircleCI!
Details
ci/circleci: testRc Your tests passed on CircleCI!
Details
cla/palantir CLA signed on 2018-06-15 09:17 UTC+00:00
Details
@adidahiya adidahiya referenced this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.