Skip to content
This repository has been archived by the owner. It is now read-only.

Fix false positive for simple parenthesized array types with array-simple (#4844) #4846

Merged
merged 1 commit into from Aug 31, 2019

Conversation

MaximeKjaer
Copy link
Contributor

@MaximeKjaer MaximeKjaer commented Aug 30, 2019

PR checklist

Overview of change:

(T) is now considered a simple type if T is a simple type.

Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

[bugfix] Fix false positive for simple parenthesized array types with array-simple (#4844)

@palantirtech
Copy link
Member

palantirtech commented Aug 30, 2019

Thanks for your interest in palantir/tslint, @MaximeKjaer! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Great first PR, thanks @MaximeKjaer! 🚀

@JoshuaKGoldberg JoshuaKGoldberg merged commit 89d731f into palantir:master Aug 31, 2019
14 checks passed
This was referenced Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants