From 6856f7bebd69c74a8b50272e1064e082ca9326dc Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Sun, 26 Apr 2020 15:42:44 -0400 Subject: [PATCH 1/2] Removed unused isPrivateIdentifier helper --- src/language/utils.ts | 6 ------ src/rules/noUnnecessaryQualifierRule.ts | 8 +++++++- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/language/utils.ts b/src/language/utils.ts index affebde00ba..9160d82b508 100644 --- a/src/language/utils.ts +++ b/src/language/utils.ts @@ -582,9 +582,3 @@ export function isWhiteSpace(ch: number): boolean { // tslint:disable-next-line return (ts.isWhiteSpaceLike || (ts as any).isWhiteSpace)(ch); } - -/** Wrapper for compatability with typescript@<3.8.2 */ -export function isPrivateIdentifier(node: ts.Node): node is ts.PrivateIdentifier { - // tslint:disable-next-line - return ts.isPrivateIdentifier ? ts.isPrivateIdentifier(node) : false; -} diff --git a/src/rules/noUnnecessaryQualifierRule.ts b/src/rules/noUnnecessaryQualifierRule.ts index 6928c4d1656..887c7e3380b 100644 --- a/src/rules/noUnnecessaryQualifierRule.ts +++ b/src/rules/noUnnecessaryQualifierRule.ts @@ -64,7 +64,7 @@ function walk(ctx: Lint.WalkContext, checker: ts.TypeChecker): void { case ts.SyntaxKind.PropertyAccessExpression: const { expression, name } = node as ts.PropertyAccessExpression; - if (utils.isEntityNameExpression(expression) && !Lint.isPrivateIdentifier(name)) { + if (utils.isEntityNameExpression(expression) && !isPrivateIdentifier(name)) { visitNamespaceAccess(node, expression, name); break; } @@ -152,3 +152,9 @@ function tryGetAliasedSymbol(symbol: ts.Symbol, checker: ts.TypeChecker): ts.Sym ? checker.getAliasedSymbol(symbol) : undefined; } + +/** Wrapper for compatability with typescript@<3.8.2 */ +export function isPrivateIdentifier(node: ts.Node): node is ts.PrivateIdentifier { + // tslint:disable-next-line + return ts.isPrivateIdentifier ? ts.isPrivateIdentifier(node) : false; +} From 0beda59d4c9cfca5237dc422c266e2f48625ea72 Mon Sep 17 00:00:00 2001 From: Adi Dahiya Date: Sun, 26 Apr 2020 21:57:54 -0400 Subject: [PATCH 2/2] Update src/rules/noUnnecessaryQualifierRule.ts --- src/rules/noUnnecessaryQualifierRule.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rules/noUnnecessaryQualifierRule.ts b/src/rules/noUnnecessaryQualifierRule.ts index 887c7e3380b..cace039a55d 100644 --- a/src/rules/noUnnecessaryQualifierRule.ts +++ b/src/rules/noUnnecessaryQualifierRule.ts @@ -154,7 +154,7 @@ function tryGetAliasedSymbol(symbol: ts.Symbol, checker: ts.TypeChecker): ts.Sym } /** Wrapper for compatability with typescript@<3.8.2 */ -export function isPrivateIdentifier(node: ts.Node): node is ts.PrivateIdentifier { +function isPrivateIdentifier(node: ts.Node): node is ts.PrivateIdentifier { // tslint:disable-next-line return ts.isPrivateIdentifier ? ts.isPrivateIdentifier(node) : false; }