Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually properly support async #82

merged 11 commits into from Dec 14, 2022

Actually properly support async #82

merged 11 commits into from Dec 14, 2022


Copy link

@palfrey palfrey commented Dec 11, 2022

As part of the investigations for #78, I found out that the async support was pretty broken. OTOH, this mostly didn't matter, as most async test frameworks (certainly tokio and actix) both mess around with the function form enough in their macros so you could still write async test functions with them fine.

wasm_bindgen_test is less forgiving, and we now test with that explicitly.

@palfrey palfrey mentioned this pull request Dec 11, 2022
@palfrey palfrey merged commit 4330da4 into main Dec 14, 2022
7 checks passed
@palfrey palfrey deleted the actual-async branch December 14, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant