Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taskbar or menu icons hard to see when both have different background #39

Closed
hmollercl opened this issue Jun 4, 2019 · 6 comments

Comments

Projects
None yet
2 participants
@hmollercl
Copy link

commented Jun 4, 2019

Since icons.cpp use symbolic icons for taskbar and menu, when taskbar has a dark background and menu light, icons are hard to see in task bar but does look good in menu.

network-manager from gnome use non symbolic for both, and they end up showing good in task bar but bad in menu, however, when mouse-over the connection they look good (it add a dark background on mouse-over)

In the menu is problematic for wireless signal since the icon show signal strength.

My suggestion would be to use symbolic icons for menu, but non-symbolic for taskbar.

@hmollercl hmollercl changed the title Taskbar or menu icons get lost when both have different background Taskbar or menu icons hard to see when both have different background Jun 4, 2019

@palinek

This comment has been minimized.

Copy link
Owner

commented Jun 4, 2019

I can see nothing that can be done here on nm-tray's side. Other user (use case) can require just the opposite of your suggestion.

You can

  • use icon theme w/o *-symbolic icons
  • use configuration options (if any) of your panel
@hmollercl

This comment has been minimized.

Copy link
Author

commented Jun 5, 2019

To clarify, here are some screenshots. In the first one you see both taskbar icons, the dark one is nm-tray which also has its connection menu open. As you can see nm-tray taskbar icon is hard to see but connections icons are ok. On the other hand network-manager-gnome (non symbolic) taskbar icon looks white.
nm-tray1
In the second one, you can also see both taskbar icons, but in this case the menu icons are hard to see (non-symbolic) of netwoork-manager-gnome.
nm-tray2
In the third screenshot you can see how lxqt-powermanagement handles the issues in a good manner, taskbar icon light on dark taskbar but menu icons dark on light background. In case of the menu it uses xdg:icon https://github.com/lxqt/lxqt-powermanagement/blob/master/src/trayicon.cpp#L61 and it doesn't use symbolic for taskbar icon (even when it use the theme icon) https://github.com/lxqt/lxqt-powermanagement/blob/master/src/iconproducer.cpp
nm-tray3

My understanding is that symbolic icons are for instances where you don't want/need fancy icons (https://wiki.gnome.org/Design/OS/SymbolicIcons), I agree with that in the menu, but not necessary in today's taskbars/panel.
That's why I would suggest using symbolic for menus but not for taskbar, but there might be other approaches.
I agree that changing the icon theme to a more colorful ones would solve the issue, also having menu and taskbar with same background color. But there are other programs that already have solved this, like lxqt-powermanagement.

@palinek

This comment has been minimized.

Copy link
Owner

commented Jun 5, 2019

Please, check if https://github.com/palinek/nm-tray/commits/icon_symbolic implements your suggestion.

@hmollercl

This comment has been minimized.

Copy link
Author

commented Jun 5, 2019

wow, that was quick! Thanks! At least with wired connection worked like a charm, tonight I will test it with wireless and let you know.

@hmollercl

This comment has been minimized.

Copy link
Author

commented Jun 6, 2019

perfect, that solve the issue, non-symbolic tray icon, simbolic for the list
thanks!
nm-tray-solved

@palinek palinek added the enhancement label Jun 6, 2019

@palinek

This comment has been minimized.

Copy link
Owner

commented Jun 6, 2019

Merged into master -> ecbe243

@palinek palinek closed this Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.