Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add belongs_to association #30

Merged
merged 3 commits into from Mar 20, 2019

Conversation

Projects
None yet
2 participants
@madding
Copy link
Contributor

commented Mar 5, 2019

No description provided.

@madding madding changed the title Add belongs_to association [WIP] Add belongs_to association Mar 5, 2019

@madding madding force-pushed the madding:add-belongs-to-association branch from c5d1b87 to 7cc7854 Mar 6, 2019

@madding madding changed the title [WIP] Add belongs_to association Add belongs_to association Mar 6, 2019

@madding madding force-pushed the madding:add-belongs-to-association branch from fc7439d Mar 6, 2019

@madding madding force-pushed the madding:add-belongs-to-association branch to 196b15f Mar 6, 2019

@ssnickolay
Copy link
Collaborator

left a comment

Don't forget to update CHANGELOG ;)

Show resolved Hide resolved spec/clowne/integrations/active_record_belongs_to_spec.rb
Show resolved Hide resolved spec/clowne/adapters/active_record/associations/belongs_to_spec.rb
Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md Outdated

madding added some commits Mar 9, 2019

@madding

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2019

I fixed all by review.

@ssnickolay

This comment has been minimized.

Copy link
Collaborator

commented Mar 11, 2019

@madding Good job! Will be merged in the coming days.
Do you have a twitter account for mentioning in the release?

@madding

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2019

Yes, I have https://twitter.com/MaddingG

@ssnickolay ssnickolay merged commit 0c099de into palkan:master Mar 20, 2019

1 check passed

codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.