rsync does not use port from host configuration #157

Closed
guv opened this Issue Aug 20, 2012 · 1 comment

Projects

None yet

2 participants

@guv

I have a nodelist provider which contains several nodes with the same IP but different ports since they are referring to SSH tunnels through the same gateway.

Remote script execution works as expected.
But the pallet.action.rsync/rsync function does not use the port information that is specified in the nodes of the nodelist provider.

@guv

When you patch this you could add support for optional flags that are passed to the actual rsync script call.
For example the current 0.7.1 implementation does not preserve the timestamps since the flag is no set.
With the flags-option this could be chosen by the user.

@hugoduncan hugoduncan added a commit that closed this issue Aug 30, 2012
@hugoduncan hugoduncan Default rsync port from target node
The ssh port is taken from the target node. Extra options can now be specified.
Fixes #157
3ea85ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment