-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds NextFormMixin
to match intended behavior
#331
Conversation
Actually, this doesn't seem to fix this either. The |
Whoops, forgot to fill in the next field! Works as expected now! |
So 'next' definitely works in the verify form - we have a unit test for that - and you can see it in the VerifyForm itself. You can see the test: test_verify_fresh |
@jwag956 Yeah, I looked at that but I am not sure why it doesn't quite work in our use case. We have a custom verify template and a custom form (extended from |
Would you be able to upload your form and template? |
Here is our
Here is our old one:
Here is a sample template we were using:
|
Thanks - I guess I am wondering where you are even setting 'next'? This in turn calls a method used by all redirects: So it first looks at the request args, then at the request form. Which from what I can tell is precisely the the NextMixin does - so it isn't clear why it isn't working. Is there anywhere in your FORM that you are setting 'next'? (I didn't see it). |
That's where the problem seems to lie. I tried adding print statements in |
Oh - I am not opposed to your PR - since it is basically similar code to other views - I wish I understood why it works and the current code doesn't :-) Also - I would appreciate a unit test.. Actually - I/we really need to understand what's going on - there is a lot of legacy code in this code base (3 different places that mess with 'next') - that I would like to see if it can be simplified. |
Nice sleuthing - could you include your FS config? |
Totally understand 😃 - I am not too sure why this is happening either as the
Here is the FS config for what we are testing:
Here is the url we are testing against: Also, it looks like |
Hmm - here is a test I wrote to try to reproduce - still working as I expect (you can put this in test_misc.py):
|
I am going to close this - I can't reproduce the issue, and have added a test that mimics as best I could the original issue - and everything still works as intended. If a repro case can be found - please open an issue |
On the documentation, the intended use case for VerifyForm shows that the
next
form should be used but it looks likeNextFormMixin
is missing from the Form itself.