Skip to content

utf8 for mysql #875

@drewbutcher

Description

@drewbutcher

In the __init__.py file these is a default value of 'utf8' for charset with the mysql driver which causes an warning in the pymysql package. Could we update the 'utf8' to 'utf8mb4'?

Expected Behavior

I would like to remove the warning when the sever restarts (after every code change while in development). I made a change in my version around like 877 to

        if sa_url.drivername.startswith('mysql'):
            sa_url.query.setdefault('charset', 'utf8mb4')

Actual Behavior

When I start my server I receive a warning about utf8 being an alias for utf8mb3

/venv/lib/python3.7/site-packages/pymysql/cursors.py:170: Warning: (3719, "'utf8' is currently an alias for the character set UTF8MB3, but will be an alias for UTF8MB4 in a future release. Please consider using UTF8MB4 in order to be unambiguous.")

Environment

  • Python version: 3.7
  • Flask-SQLAlchemy version: 2.4.1
  • SQLAlchemy version: 1.3.11

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions