wtforms.validators.URL does not allow query parameters in the URL

[laurihy]

Using wtforms.validators.URL to validate URL with query parameters incorrectly returns False.

import wtforms
 
class URLForm(wtforms.Form):
     url = wtforms.StringField('MyLink', validators=[wtforms.validators.URL()])
 
URLForm(url='https://example.com').validate()
# -> True

URLForm(url='https://example.com?this=fails').validate()
# -> False, but this should be True as it's a valid URL

Seems like this is because the regex used in URL validation incorrectly includes query parameters to the hostname, and then HostnameValidation fails.

https://github.com/wtforms/wtforms/blob/master/src/wtforms/validators.py#L498

import re
from wtforms.validators import HostnameValidation
url_regex = re.compile(r"^[a-z]+://(?P<host>[^/:]+)(?P<port>:[0-9]+)?(?P<path>\/.*)?$")
match  = url_regex.match('https://example.com?query=params')
print(match.group('host'))
# -> example.com?query=params
HostnameValidation(match.group('host'))
# -> False

Instead, the regex should separate hostname and query parameters, and only use the actual hostname for HostnameValidation.

I'll cook up a PR to fix this later this week, unless someone is faster than that :)

[laurihy]

#524 should fix this