Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Expand unit testing around termui, especially getchar #1116
#1115, #583, and a couple of other issues seem to show that there are some subtle cases to handle in
I think it would be nice to have some more testing around the termui module, limited to what we can do safely and definitely correctly -- e.g. feed
The best way to tackle this is probably to start writing more tests and see what's needed and possible.
referenced this issue
May 9, 2019
My big worry was about Windows coverage. For the issues I mentioned, I was firing up Windows VMs and poking and prodding at it, without any kind of tests as a safety net.
I would say that #1315 closes this. At a glance it seems fine/good, but I want to do a more careful read after work before merging.