option with bool type

[Cologler]

@click.command()
@click.option('--shout/--no-shout', default=False)
def info(shout):
    pass

info()

is ok, but

@click.command()
@click.option('--shout/--no-shout', default=False, type=bool)
def info(shout):
    pass

info()

will raise a TypeError: Got secondary option for non boolean flag.

[jab]

I've tracked this down to

click/click/core.py

Line 1573 in c6042bf

and type is None:

in this case type is not None, it's bool, so the condition is failing and self.is_bool_flag incorrectly gets set to False.

I can't immediately see why this is there (it just looks wrong at first glance). But blame says that line of code is 5 years old, which suggests there's more to it...

[Cologler]

I am working on a click helper library (https://github.com/Cologler/click-anno-python), so I was did a lot of tests for click.

[davidism]

I think this is there because the --no- option makes this a special type of boolean flag automatically, it wouldn't make sense to assign a type to it. I guess we could check if type is none or bool.

[jab]

Huh, I’d have thought using the /--no- spelling should imply type=bool, so you wouldn’t have to add that explicitly, but if you did, it would mean the same thing.

[Ketzalkotal]

Taking a look at this

[Ketzalkotal]

Checked the Discord, it looks like KP has got it

[xingheng]

Same here. type=click.BOOL repros this bug, too. Temporarily remove the type and resolved.

[Xevion]

The type argument only supports bool and not click.BOOL, should this be changed to support both?

click/src/click/core.py

Line 1780 in 9cfa961

if self.is_flag and isinstance(self.flag_value, bool) and type in [None, bool]: