Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ParameterSource an Enum #1530

Closed
davidism opened this issue Apr 20, 2020 · 2 comments · Fixed by #1535
Closed

Make ParameterSource an Enum #1530

davidism opened this issue Apr 20, 2020 · 2 comments · Fixed by #1535
Labels
f:parameters feature: input parameter types
Milestone
8.0.0

Comments

@davidism
Copy link
Member

core.ParameterSource was implemented as fake enum for compatibility with Python 2. Replace this with a simple enum.Enum now that we support Python >= 3.6. Can remove the ParameterSource.validate method too, it was just for ensuring the enum values were used.
@davidism davidism added this to the 8.0 milestone Apr 20, 2020
@alanbato
Copy link
Contributor

I'd like to work on this!

@davidism
Copy link
Member Author

Go for it, no need to comment first! :-) I just merged a big PR, so make sure your repo is up to date before you start.

@alanbato alanbato mentioned this issue Apr 20, 2020
Merged
@davidism davidism added the f:parameters feature: input parameter types label Oct 7, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
f:parameters feature: input parameter types
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Make ParameterSource a proper Python 3 Enum subclass. alanbato/click
2 participants
@davidism @alanbato