Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move iterable checks from type_cast_value to __init__ #1806

Closed
davidism opened this issue Mar 5, 2021 · 2 comments · Fixed by #1852
Closed

Move iterable checks from type_cast_value to __init__ #1806

davidism opened this issue Mar 5, 2021 · 2 comments · Fixed by #1852
Assignees
@davidism
Milestone
8.0.0

Comments

@davidism
Copy link
Member

davidism commented Mar 5, 2021

Both the errors raised in type_cast_value should be in __init__ instead. The composite error should be removed from type_cast_value, it makes no sense at runtime. Both places that value is iterated in type_cast_value should raise a BadParameter error instead of TypeError.

Originally posted by @davidism in #1805 (comment)
@davidism
Copy link
Member Author

davidism commented Mar 5, 2021

@Saif807380 want to work on this?

@Saif807380
Copy link
Contributor

Sure. I'll have a go at it.

@Saif807380 Saif807380 mentioned this issue Mar 6, 2021
Closed
6 tasks
@davidism davidism added this to the 8.0.0 milestone Mar 10, 2021
@davidism davidism assigned davidism and unassigned Saif807380 Apr 3, 2021
@davidism davidism mentioned this issue Apr 15, 2021
Merged
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidism davidism

Labels
None yet
Projects
None yet
Milestone
8.0.0
2 participants
@davidism @Saif807380