Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash completion for MultiCommands returns subcommands twice until it stops. #471

Closed
rubot opened this issue Nov 27, 2015 · 5 comments

Comments

@rubot
Copy link

commented Nov 27, 2015

Python 2.7.10
broken in click >= 6
ok in click (5.1)

manage hello hello world world
@danielsnider

This comment has been minimized.

Copy link

commented Dec 3, 2015

+1
Still a problem in click v6.2

Bash completion isn't working properly beyond the first click command level.

@bb4242

This comment has been minimized.

Copy link
Contributor

commented Dec 15, 2015

I've noticed this problem as well. Some git bisect experiments indicate that the problem was introduced in commit 0a2919f on Nov 24th.

@kuchi

This comment has been minimized.

Copy link

commented Mar 23, 2016

Still observing this issue with click v 6.3 and the current development branch 57c6f09. (Using python 2.7 on OS X in ZSH using bashcomplete (bashcompinit).

instead of getting tab completion providing:

cmd sub_cmd1 cmd_1_options ...

Autocomplete endlessly completes at the sub command level and never moves into the sub_command itself for auto completion:

cmd sub_cmd1 sub_cmd1 sub_cmd1 ....

Downgrading to click v 5.1 fixes the issue.

pip uninstall click
pip install -Iv click==5.1
@untitaker

This comment has been minimized.

Copy link
Member

commented Mar 23, 2016

(edit because wrong user mentioned)

@bb4242 Thank you very much for the bisect, the fix is now obvious to me.

@untitaker untitaker closed this in 37011e7 Mar 23, 2016
@untitaker

This comment has been minimized.

Copy link
Member

commented Mar 24, 2016

6.5 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.