Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a memory leak and missing error check in _get_windows_argv #1136

Merged
merged 1 commit into from Feb 24, 2020

Conversation

@segevfiner
Copy link
Contributor

segevfiner commented Oct 7, 2018

Fixes #495

@segevfiner segevfiner force-pushed the segevfiner:winconsole-memory-leak branch from c86be98 to f014a47 Oct 7, 2018
@davidism davidism added this to the 7.1 milestone Feb 23, 2020
@davidism davidism added the windows label Feb 23, 2020
@davidism davidism force-pushed the segevfiner:winconsole-memory-leak branch from f014a47 to f957fba Feb 24, 2020
@davidism davidism changed the base branch from master to 7.x Feb 24, 2020
@davidism davidism merged commit f546f06 into pallets:7.x Feb 24, 2020
10 checks passed
10 checks passed
Tests Build #20200224.2 succeeded
Details
Tests (Job Docs) Job Docs succeeded
Details
Tests (Job PyPy 3 Linux) Job PyPy 3 Linux succeeded
Details
Tests (Job Python 2.7 Linux) Job Python 2.7 Linux succeeded
Details
Tests (Job Python 2.7 Windows) Job Python 2.7 Windows succeeded
Details
Tests (Job Python 3.5 Linux) Job Python 3.5 Linux succeeded
Details
Tests (Job Python 3.6 Linux) Job Python 3.6 Linux succeeded
Details
Tests (Job Python 3.7 Linux) Job Python 3.7 Linux succeeded
Details
Tests (Job Python 3.7 Mac) Job Python 3.7 Mac succeeded
Details
Tests (Job Python 3.7 Windows) Job Python 3.7 Windows succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.