Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meaningful filename for old globals.py #1196

Closed
wants to merge 2 commits into from

Conversation

julianogouveia
Copy link

@julianogouveia julianogouveia commented Dec 28, 2018

Reading the click project code, I found a poor meaning for the globals.py file. I believe that the name context.py is better, so I renamed the file for it, so with the get_current_context function for only get_context, which makes the code more understandable and cleaner.

I hope you guys enjoy the contribution.

Thks.

@davidism
Copy link
Member

davidism commented Dec 29, 2018

Thanks, but renames like this are not backwards compatible and don't really improve the code.

@davidism davidism closed this Dec 29, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants