Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always return originally passed choice for Choice() #1318

Conversation

@altendky
Copy link
Contributor

commented May 11, 2019

closes #1277
replaces #1278

Copy link
Contributor

left a comment

I'm sorry that this took me so long to circle back to and review. I got pulled into other projects (after we spent good effort discussing this behavior, that feels like a waste).

I think this is the right thing to do. Even after a while away from it, reading it makes sense and is pretty reasonable.

I'd like to merge, but before I do, I had one comment about lower vs casefold. Let me know what you think about that.

click/types.py Show resolved Hide resolved
@sirosen sirosen force-pushed the altendky:1277-altendky-return_exact_from_choice_insensitive branch from 4f76c57 to 89e74e8 Sep 26, 2019
@sirosen

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2019

Just to keep the history a little bit clean, I rebased this before merging. (It's my own fault for taking months to review it.)

@sirosen sirosen merged commit 1a714b3 into pallets:7.x Sep 26, 2019
10 checks passed
10 checks passed
Tests Build #20190926.1 succeeded
Details
Tests (Job Docs) Job Docs succeeded
Details
Tests (Job PyPy 3 Linux) Job PyPy 3 Linux succeeded
Details
Tests (Job Python 2.7 Linux) Job Python 2.7 Linux succeeded
Details
Tests (Job Python 2.7 Windows) Job Python 2.7 Windows succeeded
Details
Tests (Job Python 3.5 Linux) Job Python 3.5 Linux succeeded
Details
Tests (Job Python 3.6 Linux) Job Python 3.6 Linux succeeded
Details
Tests (Job Python 3.7 Linux) Job Python 3.7 Linux succeeded
Details
Tests (Job Python 3.7 Mac) Job Python 3.7 Mac succeeded
Details
Tests (Job Python 3.7 Windows) Job Python 3.7 Windows succeeded
Details
@altendky altendky deleted the altendky:1277-altendky-return_exact_from_choice_insensitive branch Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.