Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct ZSH completion definitions #1348

Merged
merged 1 commit into from Aug 1, 2019
Merged

Correct ZSH completion definitions #1348

merged 1 commit into from Aug 1, 2019

Conversation

@rnc
Copy link
Contributor

rnc commented Jul 3, 2019

Supplying fix from cekit/cekit#562.
This makes it auto-loadable (and adds some error handling) - see http://zsh.sourceforge.net/Doc/Release/Completion-System.html

@jcrotts

This comment has been minimized.

Copy link
Member

jcrotts commented Jul 4, 2019

Could you add a changelog entry under 8.X, thanks for the PR.

@rnc

This comment has been minimized.

Copy link
Contributor Author

rnc commented Jul 5, 2019

Done! :-)

( Not sure why the AppVeyor CI is failing - it looks like CI setup issues? )

@jcrotts jcrotts added this to the 8.0 milestone Jul 6, 2019
@davidism davidism force-pushed the rnc:master branch from b5b83a5 to cbb3c0c Aug 1, 2019
@davidism davidism merged commit 7d11997 into pallets:master Aug 1, 2019
10 checks passed
10 checks passed
Tests Build #20190801.24 succeeded
Details
Tests (Job Docs) Job Docs succeeded
Details
Tests (Job PyPy 3 Linux) Job PyPy 3 Linux succeeded
Details
Tests (Job Python 2.7 Linux) Job Python 2.7 Linux succeeded
Details
Tests (Job Python 2.7 Windows) Job Python 2.7 Windows succeeded
Details
Tests (Job Python 3.5 Linux) Job Python 3.5 Linux succeeded
Details
Tests (Job Python 3.6 Linux) Job Python 3.6 Linux succeeded
Details
Tests (Job Python 3.7 Linux) Job Python 3.7 Linux succeeded
Details
Tests (Job Python 3.7 Mac) Job Python 3.7 Mac succeeded
Details
Tests (Job Python 3.7 Windows) Job Python 3.7 Windows succeeded
Details
@davidism davidism added the completion label Aug 1, 2019
@davidism

This comment has been minimized.

Copy link
Member

davidism commented Aug 1, 2019

I ended up force pushing to fix some merge issues. Since you submitted your master branch, it is out of sync with our master branch after merging this PR. You'll need to reset your fork to continue.

git remote add upstream https://github.com/pallets/click
git fetch upstream
git checkout master
git reset --hard upstream/master
git push -f
@davidism

This comment has been minimized.

Copy link
Member

davidism commented Feb 24, 2020

Cherry picked to 7.1 in #1480

@davidism davidism modified the milestones: 8.0, 7.1 Feb 24, 2020
@davidism

This comment has been minimized.

Copy link
Member

davidism commented Feb 26, 2020

@rnc Is the #compdef prog_name what makes this auto loadable? Where is that in the docs? What does auto loading look like?

I'm assuming (( ! $+commands[%(script_names)s] )) && return 1 is the error handling, but what exactly does it do?

The changes still work, which is why I merged them assuming you're more familiar with it, but I don't really know much about ZSH or completion. Would really appreciate an explanation so I can maintain this better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.