Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZSH completions escape #1418

Merged
merged 1 commit into from Feb 27, 2020
Merged

ZSH completions escape #1418

merged 1 commit into from Feb 27, 2020

Conversation

timka
Copy link
Contributor

@timka timka commented Oct 30, 2019

Completion in ZSH usually escapes spaces and other special characters in file names etc. I think this is the expected behavior.

As I see -Q has been introduced in stopthatcow@13b84c5 which fixed sorting. However this options seems unnecessary and unrelated to sort order.

Also, I haven't found a straightforward way to test this. In case this breaks something else I'd figure out a way to override the default completion function.

@davidism davidism added the f:completion feature: shell completion label Feb 22, 2020
@davidism davidism added this to the 7.2 milestone Feb 24, 2020
@davidism
Copy link
Member

davidism commented Feb 24, 2020

I'm unclear why you want to remove it. I had a hard time finding documentation on the -Q option to _describe, but it looks like that's what quotes values, which you said was expected.

@davidism
Copy link
Member

davidism commented Feb 27, 2020

Ah, I had it wrong, looks like -Q disabled quoting. Seems fine to remove. cc @stopthatcow

@davidism davidism modified the milestones: 7.2, 7.1 Feb 27, 2020
@davidism davidism changed the base branch from master to 7.x Feb 27, 2020
@davidism davidism merged commit 559a46c into pallets:7.x Feb 27, 2020
10 checks passed
@timka timka deleted the patch-1 branch Oct 29, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f:completion feature: shell completion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants