Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fish completion #1423

Merged
merged 3 commits into from Mar 5, 2020
Merged

Add support for fish completion #1423

merged 3 commits into from Mar 5, 2020

Conversation

@jle64
Copy link
Contributor

jle64 commented Nov 14, 2019

This adds support for fish auto-completion.

While there is already the click-completion project in click-contrib that provides fish support, it seems to me that:

  1. Since there is already completion support for zsh and bash in click and adding fish is trivial it would seems logical to have it in the same place rather than require an additional dependency

  2. Having it in click means that it is less likely to be prone to incompatibilities with other click extensions as it will not rely on monkey patching (currently I encounter issues using both click-completion and click-default-group at the same time).

See also issue #1060

@davidism davidism added the completion label Feb 22, 2020
@davidism davidism modified the milestones: 7.2, 7.1 Feb 24, 2020
@davidism davidism removed this from the 7.1 milestone Mar 5, 2020
jle64 and others added 3 commits Nov 14, 2019
@davidism davidism force-pushed the jle64:fish_complete branch from 70b926b to 6bf782e Mar 5, 2020
@davidism davidism added this to the 7.1 milestone Mar 5, 2020
@davidism davidism changed the base branch from master to 7.x Mar 5, 2020
@davidism davidism merged commit 433708e into pallets:7.x Mar 5, 2020
11 checks passed
11 checks passed
Tests Build #20200305.1 succeeded
Details
Tests (Job Docs) Job Docs succeeded
Details
Tests (Job PyPy 3 Linux) Job PyPy 3 Linux succeeded
Details
Tests (Job Python 2.7 Linux) Job Python 2.7 Linux succeeded
Details
Tests (Job Python 2.7 Windows) Job Python 2.7 Windows succeeded
Details
Tests (Job Python 3.5 Linux) Job Python 3.5 Linux succeeded
Details
Tests (Job Python 3.6 Linux) Job Python 3.6 Linux succeeded
Details
Tests (Job Python 3.7 Linux) Job Python 3.7 Linux succeeded
Details
Tests (Job Python 3.8 Linux) Job Python 3.8 Linux succeeded
Details
Tests (Job Python 3.8 Mac) Job Python 3.8 Mac succeeded
Details
Tests (Job Python 3.8 Windows) Job Python 3.8 Windows succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.