Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in new AppEngine environments #1462

Merged
merged 1 commit into from Jan 30, 2020
Merged

Fix error in new AppEngine environments #1462

merged 1 commit into from Jan 30, 2020

Conversation

@aaronsarna
Copy link
Contributor

aaronsarna commented Jan 30, 2020

Newer AppEngine environments don't define the SERVER_SOFTWARE env variable. Without this change, importing click dies with a KeyError.

See related pull request for urllib3: urllib3/urllib3#1704

Newer AppEngine environments don't define the SERVER_SOFTWARE env variable. Without this change, importing click dies with a KeyError.

See related pull request for urllib3: urllib3/urllib3#1704
@aaronsarna aaronsarna requested a review from zacbir Jan 30, 2020
@jab jab merged commit ff06fa2 into pallets:master Jan 30, 2020
10 checks passed
10 checks passed
Tests Build #20200130.1 succeeded
Details
Tests (Job Docs) Job Docs succeeded
Details
Tests (Job PyPy 3 Linux) Job PyPy 3 Linux succeeded
Details
Tests (Job Python 2.7 Linux) Job Python 2.7 Linux succeeded
Details
Tests (Job Python 2.7 Windows) Job Python 2.7 Windows succeeded
Details
Tests (Job Python 3.5 Linux) Job Python 3.5 Linux succeeded
Details
Tests (Job Python 3.6 Linux) Job Python 3.6 Linux succeeded
Details
Tests (Job Python 3.7 Linux) Job Python 3.7 Linux succeeded
Details
Tests (Job Python 3.7 Mac) Job Python 3.7 Mac succeeded
Details
Tests (Job Python 3.7 Windows) Job Python 3.7 Windows succeeded
Details
@jab

This comment has been minimized.

Copy link
Member

jab commented Jan 30, 2020

Thanks for the contribution!

@aaronsarna aaronsarna deleted the aaronsarna:patch-1 branch Jan 30, 2020
@aaronsarna

This comment has been minimized.

Copy link
Contributor Author

aaronsarna commented Jan 30, 2020

Any chance this can get merged into 7.x?

@jab

This comment has been minimized.

Copy link
Member

jab commented Jan 31, 2020

See #1463.

jab added a commit that referenced this pull request Jan 31, 2020
jab added a commit that referenced this pull request Jan 31, 2020
@davidism davidism added this to the 8.0 milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.