Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in new AppEngine environments #1462

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Conversation

aaronsarna
Copy link
Contributor

Newer AppEngine environments don't define the SERVER_SOFTWARE env variable. Without this change, importing click dies with a KeyError.

See related pull request for urllib3: urllib3/urllib3#1704

Newer AppEngine environments don't define the SERVER_SOFTWARE env variable. Without this change, importing click dies with a KeyError.

See related pull request for urllib3: urllib3/urllib3#1704
@jab jab merged commit ff06fa2 into pallets:master Jan 30, 2020
@jab
Copy link
Member

jab commented Jan 30, 2020

Thanks for the contribution!

@aaronsarna aaronsarna deleted the patch-1 branch January 30, 2020 22:20
@aaronsarna
Copy link
Contributor Author

Any chance this can get merged into 7.x?

@jab
Copy link
Member

jab commented Jan 31, 2020

See #1463.

jab added a commit that referenced this pull request Jan 31, 2020
jab added a commit that referenced this pull request Jan 31, 2020
@davidism davidism added this to the 8.0 milestone Jan 31, 2020
@davidism davidism modified the milestones: 8.0, 7.1 Feb 24, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants