Support Debian's sensible-editor #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidism
force-pushed
the
feature/sensible-editor
branch
from
e351627
to
22bfb0c
Compare
|
Meant to target this at 7.1, didn't notice it was on master. Cherry picked in 17cc8d7. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Debian and derivative distros include a program named
sensible-editorthat is similar in spirit toEditor.get_editor(), except it also allows the user to make an interactive choice when the relevant envvars are unset:$VISUALor$EDITORif they are defined~/.selected_editoris run. If this file does not exist and input is a tty, the user is shown a list of installed text editors and asked to choose one. The choice is saved in~/.selected_editor, and then the given program is run.~/.selected_editorno longer exists,sensible-editorfalls back tonano, thennano-tiny, thenvi.This patch adds
sensible-editorto the list of editors considered byEditor.get_editor()so that determining an editor to use on Debian systems works similarly to other programs on Debian.