Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include --help option in completion #1504

Merged
merged 5 commits into from Jun 6, 2020

Conversation

tiangolo
Copy link
Contributor

@tiangolo tiangolo commented Mar 15, 2020

Include --help option in completion.

When executing completion (in Bash, Zsh, etc) the --help option is currently omitted, even though it's available.

This allows the --help option to show up in completion if it was enabled.

This is the same way it's done in click-completion: https://github.com/click-contrib/click-completion/blob/master/click_completion/core.py#L92

@tiangolo
Copy link
Contributor Author

tiangolo commented Mar 15, 2020

I'm not sure where should I add the change in CHANGES.rst, above:

Version 7.1.1
-------------

without a version title?

Or should I create a dummy unreleased version title that you change later?

@ThiefMaster
Copy link
Member

ThiefMaster commented Mar 15, 2020

could you please omit the emoji in the commit messages? while they look pretty on GitHub, they are very noisy when reading the shortlog using the git CLI.

@davidism
Copy link
Member

davidism commented Mar 15, 2020

For the changelog, just start a new 7.2 section.

@tiangolo
Copy link
Contributor Author

tiangolo commented Mar 15, 2020

could you please omit the emoji in the commit messages? while they look pretty on GitHub, they are very noisy when reading the shortlog using the git CLI.

@ThiefMaster sure thing. Just removed the hook. Changing the previous would mean force-pushing, so I won't do it, but I assume you squash and merge when/if you accept it so they won't end up in the history.

For the changelog, just start a new 7.2 section.

@davidism perfect, done.

@jcrotts jcrotts merged commit c99e0e8 into pallets:7.x Jun 6, 2020
@tiangolo
Copy link
Contributor Author

tiangolo commented Jun 6, 2020

Thanks! 🚀 🎉

@tiangolo tiangolo deleted the include-help-option branch Jun 6, 2020
@davidism davidism added this to the 8.0.0 milestone Jul 1, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants