Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always install colorama on Windows #1784

merged 1 commit into from Feb 16, 2021


Copy link

Colorama is required to provide ANSI style/color support in the Windows console. This adds it as a required dependency for Windows only.

I think in this very specific case it's ok to add this as a required dependency (on Windows). It's required to support a fairly fundamental feature, and it's way too complex to implement ourselves. It's also already fairly ubiquitous, it's installed 21 million times per month while Click is only 15 million. So it's likely that users are already pulling in this dependency or expect it to work.


  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism added this to the 8.0.0 milestone Feb 16, 2021
@davidism davidism merged commit 890e984 into master Feb 16, 2021
@davidism davidism deleted the windows-requires-colorama branch February 16, 2021 02:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

Use of Setuptools' "extras_require" for colorama?
1 participant