Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invoke type casts default values #2095

Merged
merged 1 commit into from Oct 10, 2021
Merged

invoke type casts default values #2095

merged 1 commit into from Oct 10, 2021

Conversation

@davidism
Copy link
Member

@davidism davidism commented Oct 10, 2021

#2085 reverted applying type casting when getting defaults, casting was only done when processing the values. However, invoke also relies on getting defaults, so it also needs to cast the values.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.
@davidism davidism added this to the 8.0.3 milestone Oct 10, 2021
@davidism davidism force-pushed the invoke-cast-default branch from e2a5204 to 662a30e Oct 10, 2021
@davidism davidism merged commit ba0e9dd into 8.0.x Oct 10, 2021
10 checks passed
@davidism davidism deleted the invoke-cast-default branch Oct 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant