Fix #628: Bash completion for nested commands broken#639
Closed
pgkelley4 wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
This is the same fix as xificurC did here: #630, but with added unit tests to demonstrate the issue. |
When concatenating protected_args and args, protected_args should be prepended. Otherwise the arguments are out of order and an incorrect subcommand is choosen.
| pass | ||
|
|
||
| assert list(get_choices(cli, 'lol', [], '-')) == ['--local-opt'] | ||
| assert list(get_choices(cli, 'lol', [], '')) == [] |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
pgkelley4
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When concatenating protected_args and args, protected_args
should be prepended. Otherwise the arguments are out
of order and an incorrect subcommand is choosen.