Fix test runner not saving caller env correctly #644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def test_env(): | ||
| @click.command() | ||
| def cli_env(): | ||
| click.echo('ENV={}'.format(os.environ['TEST_CLICK_ENV'])) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
isolate() captures current env variable values, overwrites them, yields, then restores them. Unfortunately the capturing code was broken and the env variables were wiped out during the restore phase.
pmezard
force-pushed
the
fix-tests-env-mocking
branch
from
3f36e04
to
0270282
Compare
|
My bad, I was lazy and did not run tox. Tests pass here on py26, py27 and manually with py35. I pushed --force the change, tell me if you prefer I pile commits fixing review comments instead. |
|
Applied to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isolate() captures current env variable values, overwrites them, yields,
then restores them. Unfortunately the capturing code was broken and the
env variables were wiped out during the restore phase.