Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #554 representation of new model instances #555

Merged
merged 4 commits into from Oct 4, 2017
Merged

Fixes #554 representation of new model instances #555

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
adae79f
Fixed representation of new model instances
jeff-99 Oct 4, 2017
116ed24
Added "transient" id for unpersisted models
jeff-99 Oct 4, 2017
6b088dc
added test for model repr transient id
Oct 4, 2017
0953f03
removed redundant is True
Oct 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion flask_sqlalchemy/model.py
View file
Open in desktop
Expand Up @@ -120,7 +120,7 @@ class Model(object):
def __repr__(self):
identity = inspect(self).identity
if identity is None:
pk = "(transient) {0}".format(id(self))
pk = "(transient {0})".format(id(self))
else:
pk = ', '.join(to_str(value) for value in identity)
return '<{0} {1}>'.format(type(self).__name__, pk)
1 change: 1 addition & 0 deletions tests/test_model_class.py
View file
Open in desktop
Expand Up @@ -43,6 +43,7 @@ class Report(db.Model):
db.create_all()

u = User(name='test')
assert repr(u).startswith("<User (transient ") is True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove is True, it's redundant

db.session.add(u)
db.session.flush()
assert repr(u) == '<User test>'
Expand Down