Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description args for description of abort() #636

Merged
merged 1 commit into from Mar 14, 2019

Conversation

@Kcrong
Copy link
Contributor

@Kcrong Kcrong commented Sep 12, 2018

Originally, get_or_404 or first_or_404 couldn't send the description about why that error happened. So I propose to add the description to the all or_404 functions.

Copy link
Member

@davidism davidism left a comment

Please add tests, docs, and changelog.

Loading

@Kcrong
Copy link
Contributor Author

@Kcrong Kcrong commented Sep 13, 2018

Hi @davidism.
I added tests and modified docs for new args.
And do you want me to change changelog in code repo? Because I couldn't find any changes of CHANGES.rst via pull request.

Loading

@rsyring rsyring added this to the 2.4 milestone Mar 9, 2019
@rsyring rsyring dismissed davidism’s stale review Mar 14, 2019

Docs and tests have been added. Will update changelog on release.

- includes tests for or_404 functions
- includes docs for new args
@rsyring rsyring changed the base branch from master to 2.x-maintenance Mar 14, 2019
@rsyring
Copy link
Contributor

@rsyring rsyring commented Mar 14, 2019

Not sure why Travis isn't running for this PR. I've ran tox locally and while I don't have py34 or pypy which Travis would tests, everything else passed.

Loading

@rsyring rsyring merged commit 8b7b249 into pallets:2.x-maintenance Mar 14, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants