Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require ssl module #3211

Closed
davidism opened this issue May 22, 2019 · 3 comments
Closed

Don't require ssl module #3211

davidism opened this issue May 22, 2019 · 3 comments
Labels
good first issue save-for-sprint Please don't pick this unless you're participating in an official sprint.

Comments

@davidism
Copy link
Member

davidism commented May 22, 2019

Python can be compiled without certain modules, including ssl. It's somewhat common for that to happen when users compile Python from source and don't have the libssl headers set up. flask.cli imports ssl unconditionally, but it's only for optional SSL cert support in the dev server, so this can be guarded with except ImportErrror. Werkzeug already has such a workaround, although it's a little more complicated than what needs to be done in Flask.

If no ssl module is imported, using the cert-related options in the CLI should raise a usage error.

@davidism davidism added this to the 1.1.0 milestone May 22, 2019
@davidism davidism added the save-for-sprint Please don't pick this unless you're participating in an official sprint. label May 22, 2019
@t3ja

This comment has been minimized.

@davidism

This comment has been minimized.

@t3ja

This comment has been minimized.

@davidism davidism removed this from the 1.1.0 milestone May 30, 2019
davidism added a commit that referenced this issue Jun 1, 2019
@davidism davidism closed this as completed Jun 1, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue save-for-sprint Please don't pick this unless you're participating in an official sprint.
Projects
None yet
Development

No branches or pull requests

2 participants